Eng 52379 traceid in logger #64
Merged
+38
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can we have reqTraceId configurable |
Collaborator
Author
Sorry but I don't follow you here. Can you please explain what do you mean when you say this? Currently, it'll either be - https://github.com/viant/xdatly/blob/main/handler/exec/context.go#L86 -- value of OR https://github.com/viant/xdatly/blob/main/handler/tracing/trace.go#L49 -- random uuid per request |
adranwit
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding traceid to logs so that all the logs (info/debug..) specific to a request can be bundled together.
Here traceid will be the adp request id based on the env and the env variables or will be some random uuid string generated by xdatly.
The key used in the logs is
reqTraceId.