-
Notifications
You must be signed in to change notification settings - Fork 1
Add tracer labeling page #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still todo: * linting / type checking * testing and acceptance testing
* Fix bugs in the gauge labelling SQL query, AND * Fix bugs in the gauge_labelling VIEW creation. * Migrate the SQL gauge labelling filter query to use the gauge_labelling VIEW.
Also update the approval tests now that I know metabolite sizes
TODO: What if the user selected specific tracer source atoms?
* Add new refresh-views admin command to the CLI
This can be empty when no gauge_label filter was applied.
This nicely also dramatically imporoves the performance of the atom count page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra step to the filtering form allowing users to select tracer atom positions that are known to find their way to the gauge.
Closes #15