feat(battery): New den._.hostname and .. #236
Merged
Conversation
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
Owner
|
Hey, @musjj. I like the idea of having them as batteries. I've added some comments for you. |
den._.hostname and ..
Owner
|
Also, if we are having new batteries, be sure to also have some tests for them in templates/ci. |
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
vic
reviewed
Mar 6, 2026
Owner
|
Looks good, just rename to |
Contributor
Author
|
Done! |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert two well-known patterns from the examples into built-in batteries:
networking.hostNameI feel that these two use-cases are common enough that they are worth being lifted up into the built-in set of batteries.
What do you think?
Also, I would like to hear if you have any better ideas for the names:
den._.set-hostname: Maybe too specific? In the future, will there be any other use-cases for auto-configuring hosts that could be included in this battery?den._.bidirectional-provider: Feels descriptive, but maybe too long?