Conversation
and also funcion-to-module if lib,config,options detected. Related: vic/den#92 See: vic/den#91 (reply in thread)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables top-level aspects to support parametric functions that accept module system arguments (lib, config, options, aspect), addressing issue #92.
Key Changes:
- Modified type system to distinguish between submodule functions and provider functions at the aspect level
- Added validation to ensure parametric functions have appropriate module system arguments
- Updated test case to demonstrate the new functionality with a parametric
aspectOnedefinition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/types.nix | Enhanced aspectsType to accept either submodule functions or providers; added aspectSubmoduleAttrs type with validation logic to verify functions have module system arguments |
| checkmate.nix | Modified test to use parametric function syntax for aspectOne and updated expectations to verify aspect.name is correctly resolved to "aspectOne" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also funcion-to-module if lib,config,options detected. Related: vic/den#92
See:
vic/den#91 (reply in thread)