docs: Phase 21 spec — point-and-tell feedback#120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Planning artifact only (no code): spec for Phase 21 — point-and-tell feedback, plus the VISION.md phase entry.
The feature: the human clicks any element in the viewer, types a note, and it lands as structured feedback (
{ nodeId, comment }oncanvas.metadata.feedback[]) that the agent reads via a newget_feedbacktool and closes viaresolve_feedback. The inverse ofcanvas_evaluate— human critique becomes machine-readable, ending the "the third card, no the OTHER one" prose loop.Why it's cheap for what it buys
Verified against current
src/— every hard piece already exists:data-node-idon every element (renderer.ts:233); detail page iframes are same-origin and Phase 19'shighlightNodealready reaches into themarchiveRepoCanvaspattern in aggregate.ts) — spec extracts a genericupdateRepoCanvasensureFreshmtime reload delivers viewer-written comments to the running MCP server with zero new plumbingReview focus — two ★ forks
metadata.feedback[](recommended) vs separate feedback.jsonget_feedback/resolve_feedback(recommended) vs one action-enum toolEverything else has a recommended default a review comment can flip. Slices: A (model/core/tools) → B (viewer UI) → C (loop integration).