I added MouldKing DIY device #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicocz
reviewed
Mar 19, 2025
Owner
vicocz
left a comment
vicocz
left a comment
There was a problem hiding this comment.
PLease add the device to README as well.
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
added 6 commits
March 20, 2025 14:22
Task<bool>.FromResult -> Task.FromResult
accesses is always under lock, therefore there is no need for volatile
vicocz
reviewed
Mar 22, 2025
BrickController2/BrickController2/DeviceManagement/MouldKing/MK_DIY.cs
Outdated
Show resolved
Hide resolved
Author
|
Ups - how could this happen! Tested on Win and Android. |
Author
|
Thank you very much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MouldKing DIY device uses Bluetooth GATT.
It's pretty simple.
I just could figure out one characteristic to write the outputvalues...