Skip to content

Conversation

@vicocz
Copy link
Owner

@vicocz vicocz commented Jul 11, 2025

No description provided.

@vicocz vicocz changed the title CI/CD Apply release version ANdroid/WunUI app CI/CD Apply release version Android/WinUI app Jul 11, 2025
@vicocz vicocz marked this pull request as ready for review July 22, 2025 18:55
@vicocz vicocz requested a review from Copilot July 22, 2025 18:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements CI/CD automation to apply release version information to Android and WinUI apps during the build process. The changes eliminate custom versioning services in favor of using MAUI's built-in AppInfo functionality and standardize version handling across platforms.

Key changes include:

  • Replacing custom platform-specific version services with MAUI's AppInfo.Current.VersionString
  • Adding centralized version properties to Directory.Build.props for consistent version management
  • Enhancing CI/CD workflows to automatically extract and apply version information from GitHub release tags
  • Updating copyright year to 2025

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Directory.Build.props Adds centralized ApplicationDisplayVersion and ApplicationVersion properties
AboutPageViewModel.cs Replaces IVersionService dependency with direct AppInfo usage
AboutPage.xaml Updates copyright year from 2024 to 2025
IVersionService.cs Removes custom versioning interface (deleted)
VersionService.cs files Removes platform-specific version service implementations
PlatformServicesModule.cs files Removes VersionService registrations from DI containers
Package.appxmanifest Updates WinUI app identity with proper naming and publisher
AndroidManifest.xml Removes hardcoded versionName attribute
BrickController2.Android.csproj Adds commented MSBuild targets for dynamic version updates
build-windows.yml Enhances workflow with release version extraction, certificate signing, and dynamic versioning
build-android.yml Adds release version extraction and applies to build process
Comments suppressed due to low confidence (2)

Vit Nemecky added 2 commits July 22, 2025 21:07
@vicocz vicocz merged commit 570e56e into default Jul 22, 2025
5 checks passed
@vicocz vicocz deleted the local/smart-versioning branch July 22, 2025 20:22
@vicocz vicocz added the enhancement New feature or request label Jul 22, 2025
@vicocz vicocz added this to the 2025.4 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant