Skip to content

Conversation

@vicocz
Copy link
Owner

@vicocz vicocz commented Jan 10, 2025

No description provided.

@vicocz vicocz marked this pull request as ready for review May 30, 2025 17:30
@vicocz vicocz requested a review from Copilot May 30, 2025 17:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue with the iOS slider not applying its step value by adding a new event subscription for value changes and an event handler to round the new value.

  • Added subscription to platformView.ValueChanged in ConnectHandler
  • Added corresponding unsubscription and a new OnControlValueChanged event handler in DisconnectHandler
  • Ensured that the slider value is rounded via SetAndRoundNewValue
Comments suppressed due to low confidence (1)

BrickController2/BrickController2.iOS/UI/CustomHandlers/ExtendedSliderHandler.cs:27

  • Consider unsubscribing the TouchDown event in DisconnectHandler to maintain symmetry with other event subscriptions and to prevent potential memory leaks if the event subscription is no longer needed.
platformView.TouchDown += StartTrackingTouch;

@vicocz vicocz merged commit 31a2f83 into default May 30, 2025
2 checks passed
@vicocz vicocz deleted the local/ios-slider-apply-step branch May 30, 2025 17:32
@vicocz vicocz added this to the 2025.4 milestone May 30, 2025
@vicocz vicocz added the bug Something isn't working label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant