Refactor: Replace inline onclick with addEventListener for better event handling#241
Merged
vicsanity623 merged 2 commits intomainfrom Mar 19, 2026
Merged
Refactor: Replace inline onclick with addEventListener for better event handling#241vicsanity623 merged 2 commits intomainfrom
vicsanity623 merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR updates the
dashboard_html.pyfile by refactoring the method of binding event handlers to the 'move up' button in the HTML document. Specifically, the inlineonclickattribute is replaced with theaddEventListenermethod for better adherence to best practices in JavaScript event handling.Technical Impact
Improved Event Handling
addEventListeneraligns with modern JavaScript practices for handling events. This method allows for multiple event listeners on the same element, which can be beneficial for extending functionality in the future.addEventListenercan be removed or altered without directly modifying the HTML structure, thus promoting cleaner code separation.Compatibility
Code Maintainability
No Side Effects
There are no expected performance impacts or side effects to existing functionality due to this change as the same handler is invoked with the same event target.