Feature #1
Open
Feature #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliaIsakhin
reviewed
Dec 12, 2019
|
|
||
| @Override | ||
| public boolean save(SchoolBook book) { | ||
| if (book != null) { |
There was a problem hiding this comment.
if (book == null) {
return false;
}
IliaIsakhin
reviewed
Dec 12, 2019
| import com.epam.izh.rd.online.entity.SchoolBook; | ||
| import com.epam.izh.rd.online.repository.BookRepository; | ||
|
|
||
| public class SimpleSchoolBookService implements BookService { |
There was a problem hiding this comment.
implements BookService<SchoolBook>, сейчас у тебя репозиторий работает с абстрактными книгами
IliaIsakhin
reviewed
Dec 12, 2019
| public boolean save(Book book) { | ||
| SchoolBook schoolBook = (SchoolBook) book; | ||
|
|
||
| if (authorService.findByFullName(schoolBook.getAuthorName(), schoolBook.getAuthorLastName()) != null) { |
There was a problem hiding this comment.
Такое authorService.findByFullName(schoolBook.getAuthorName(), schoolBook.getAuthorLastName()) лучше в переменную выносить для читаемости
IliaIsakhin
reviewed
Dec 12, 2019
| private BookRepository<SchoolBook> schoolBookBookRepository; | ||
| private AuthorService authorService; | ||
|
|
||
| public SimpleSchoolBookService() { |
There was a problem hiding this comment.
А какой смысл в этом конструкторе?
IliaIsakhin
reviewed
Dec 12, 2019
| import com.epam.izh.rd.online.entity.Author; | ||
| import com.epam.izh.rd.online.repository.AuthorRepository; | ||
|
|
||
| public class SimpleAuthorService implements AuthorService { |
There was a problem hiding this comment.
Я бы прикрутил какую-нибудь валидацию, например на save Author != null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.