Skip to content

fix(skin): fix HTML skin poster image alignment#1002

Merged
sampotts merged 1 commit intomainfrom
fix/html-poster
Mar 18, 2026
Merged

fix(skin): fix HTML skin poster image alignment#1002
sampotts merged 1 commit intomainfrom
fix/html-poster

Conversation

@sampotts
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 11:10
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Mar 18, 2026 11:13am

Request Review

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 18, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit aaafea5
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69ba88d6ad8ab5000890afb7
😎 Deploy Preview https://deploy-preview-1002--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the base HTML skin CSS so that slotted poster content aligns/fills the player container the same way the <video> element does.

Changes:

  • Extend the existing video-player video sizing rule to also apply to video-player [slot="poster"].

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread packages/html/src/define/base.css Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2026

📦 Bundle Size Report

🎨 @videojs/html

(no changes)

Presets (7)
Entry Size
/video (default) 22.96 kB
/video (default + hls) 153.43 kB
/video (minimal) 22.85 kB
/video (minimal + hls) 153.24 kB
/audio (default) 21.24 kB
/audio (minimal) 21.21 kB
/background 6.34 kB
Media (5)
Entry Size
/media/background-video 617 B
/media/container 1.58 kB
/media/dash-video 235.71 kB
/media/hls-video 131.17 kB
/media/simple-hls-video 11.94 kB
Players (3)
Entry Size
/video/player 6.21 kB
/audio/player 6.20 kB
/background/player 6.19 kB
Skins (16)
Entry Type Size
/video/minimal-skin.css css 3.09 kB
/video/skin.css css 3.11 kB
/video/minimal-skin js 22.06 kB
/video/minimal-skin.tailwind js 22.33 kB
/video/skin js 22.20 kB
/video/skin.tailwind js 22.54 kB
/audio/minimal-skin.css css 2.25 kB
/audio/skin.css css 2.29 kB
/audio/minimal-skin js 20.47 kB
/audio/minimal-skin.tailwind js 20.48 kB
/audio/skin js 20.54 kB
/audio/skin.tailwind js 20.74 kB
/background/skin.css css 124 B
/background/skin js 999 B
/base.css css 157 B
/shared.css css 43 B
UI Components (21)
Entry Size
/ui/alert-dialog 2.11 kB
/ui/alert-dialog-close 1.59 kB
/ui/alert-dialog-description 1.51 kB
/ui/alert-dialog-title 1.49 kB
/ui/buffering-indicator 1.78 kB
/ui/captions-button 1.81 kB
/ui/controls 1.61 kB
/ui/fullscreen-button 1.84 kB
/ui/mute-button 1.83 kB
/ui/pip-button 1.81 kB
/ui/play-button 1.80 kB
/ui/playback-rate-button 1.86 kB
/ui/popover 3.34 kB
/ui/poster 1.72 kB
/ui/seek-button 1.81 kB
/ui/slider 2.00 kB
/ui/thumbnail 2.19 kB
/ui/time 1.64 kB
/ui/time-slider 2.15 kB
/ui/tooltip 2.43 kB
/ui/volume-slider 2.19 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react

(no changes)

Presets (7)
Entry Size
/video (default) 18.84 kB
/video (default + hls) 149.53 kB
/video (minimal) 18.84 kB
/video (minimal + hls) 149.73 kB
/audio (default) 14.91 kB
/audio (minimal) 14.97 kB
/background 3.13 kB
Media (4)
Entry Size
/media/background-video 476 B
/media/dash-video 236.19 kB
/media/hls-video 131.59 kB
/media/simple-hls-video 12.34 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 3.09 kB
/video/skin.css css 3.11 kB
/video/minimal-skin js 18.76 kB
/video/minimal-skin.tailwind js 21.93 kB
/video/skin js 18.75 kB
/video/skin.tailwind js 21.95 kB
/audio/minimal-skin.css css 2.25 kB
/audio/skin.css css 2.29 kB
/audio/minimal-skin js 14.93 kB
/audio/minimal-skin.tailwind js 16.96 kB
/audio/skin js 14.86 kB
/audio/skin.tailwind js 17.18 kB
/background/skin.css css 90 B
/background/skin js 272 B
UI Components (18)
Entry Size
/ui/alert-dialog 2.21 kB
/ui/buffering-indicator 2.21 kB
/ui/captions-button 2.28 kB
/ui/controls 2.20 kB
/ui/fullscreen-button 2.30 kB
/ui/mute-button 2.27 kB
/ui/pip-button 2.23 kB
/ui/play-button 2.25 kB
/ui/playback-rate-button 2.24 kB
/ui/popover 3.33 kB
/ui/poster 2.02 kB
/ui/seek-button 2.26 kB
/ui/slider 3.11 kB
/ui/thumbnail 2.03 kB
/ui/time 1.93 kB
/ui/time-slider 2.81 kB
/ui/tooltip 3.23 kB
/ui/volume-slider 2.67 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core

(no changes)

Entries (6)
Entry Size
. 4.78 kB
/dom 8.41 kB
/dom/media/custom-media-element 1.81 kB
/dom/media/dash 235.62 kB
/dom/media/hls 131.27 kB
/dom/media/simple-hls 11.85 kB

🏷️ @videojs/element

(no changes)

Entries (2)
Entry Size
. 999 B
/context 936 B

📦 @videojs/store

(no changes)

Entries (3)
Entry Size
. 1.32 kB
/html 700 B
/react 360 B

🔧 @videojs/utils

(no changes)

Entries (10)
Entry Size
/array 104 B
/dom 1.25 kB
/events 227 B
/function 261 B
/object 119 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B

📦 @videojs/spf

(no changes)

Entries (3)
Entry Size
. 40 B
/dom 10.04 kB
/playback-engine 9.94 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

@sampotts sampotts merged commit 6d76449 into main Mar 18, 2026
19 of 20 checks passed
@sampotts sampotts deleted the fix/html-poster branch March 18, 2026 11:15
@luwes luwes mentioned this pull request Mar 18, 2026
@luwes luwes mentioned this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants