fix(site): use client:idle for ejected skin tabs so hidden panels hydrate#1137
Merged
fix(site): use client:idle for ejected skin tabs so hidden panels hydrate#1137
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (6)
Players (3)
Skins (16)
UI Components (21)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (5)
Skins (14)
UI Components (18)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (7)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
decepulis
reviewed
Mar 26, 2026
Collaborator
decepulis
left a comment
There was a problem hiding this comment.
Classic. I've made this mistake before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1136
Summary
The "skin.css" / "CSS" tab on the skins docs page doesn't reveal its code snippet when clicked. Non-initial
TabsPanelislands start withhidden, which preventsclient:visible(Intersection Observer) from ever triggering hydration — so the MutationObserver that toggles panel visibility never gets set up.Changes
client:visibletoclient:idleinEjectedSkin.astroso hidden panels hydrate after page idleThis follows the existing guidance in the
Tabs.tsxcomponent comment (lines 11-14).Testing
pnpm build:site— builds clean/docs/framework/react/concepts/skins, click "skin.css" tab — code snippet should now appearNote
Low Risk
Low risk doc-site change that only alters Astro island hydration timing for tabs; main risk is minor performance/behavior differences from earlier hydration.
Overview
Fixes the ejected skin docs tabs so non-initial panels (e.g.
skin.css/CSS) reliably hydrate and reveal their code when selected.This switches the tabs islands in
EjectedSkin.astrofromclient:visibletoclient:idle, avoiding the case where initiallyhiddenpanels never become “visible” to trigger hydration.Written by Cursor Bugbot for commit 0a691cc. This will update automatically on new commits. Configure here.