fix(site): update text link hover style to gold underline#1149
Merged
fix(site): update text link hover style to gold underline#1149
Conversation
Test page at /hover-styles showing 8 different link hover style proposals for issue #810. Includes VHS/retro-themed options like chromatic aberration, scanlines, color inversion, and bracket markers. https://claude.ai/code/session_01Bde6SETLP8nGm6mFVeednB
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (8)
Players (3)
Skins (17)
UI Components (24)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (7)
Skins (14)
UI Components (19)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (8)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
- Text set to P2 size to match actual site body text - Kept: underline color shift, color inversion, chromatic aberration - Removed: thick underline, scanlines, slide-in, brackets, combo - Color shift & inversion: instant (no transition) - Chromatic aberration: short 0.15s transition, underline unchanged https://claude.ai/code/session_01Bde6SETLP8nGm6mFVeednB
…erline Replace `intent:no-underline` with `intent:decoration-gold` across all text links and link-styled buttons. On hover/focus, the underline now shifts to gold instead of disappearing, preserving the link affordance. Closes #810 https://claude.ai/code/session_01Bde6SETLP8nGm6mFVeednB
decepulis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #810.
Text links currently lose their underline on hover, which removes the visual affordance that something is a link. This PR changes the hover behavior so the underline stays visible but shifts to gold (
decoration-gold), giving clear interactive feedback without losing the link signal.intent:no-underline→intent:decoration-goldacross all text links and link-styled buttonsgroup-intent:no-underline→group-intent:decoration-goldon blog post card titlesScope: This only affects underlined text links and link-styled buttons. Navigation links, buttons, and other interactive elements that use
intent:bg-*hover styles are unchanged. Links that useintent:underline(add underline on hover) are also left as-is.Design note
This is the most conservative of the styles we explored — it preserves the existing underline pattern and simply adds a color shift for feedback. The door is still open to something more forward and branded (chromatic aberration, color inversion, etc.) if we want to lean harder into the retro/VHS aesthetic down the road.
Test plan
intent:bg-*nav/button hover styles are unaffectedTabto links) shows the same gold underlinehttps://claude.ai/code/session_01Bde6SETLP8nGm6mFVeednB
Note
Low Risk
Low risk visual-only change: updates Tailwind hover intent classes for underlined text links and link-styled buttons, plus a small test assertion update.
Overview
Updates text-link hover styling across the site so underlines no longer disappear on hover; they remain visible and switch to a gold decoration.
Replaces
intent:no-underlinewithintent:decoration-gold(andgroup-intentequivalents) in footers, the legacy banner, blog post cards, docs “Edit page” link, and installation UI link/buttons. Also updates shared typography link classes used by MDX/inline markdown and adjusts the relatedrenderInlineMarkdowntest expectation.Reviewed by Cursor Bugbot for commit 3587b0a. Bugbot is set up for automated code reviews on this repo. Configure here.