fix(build): auto-stamp changelog version from release manifest#1179
Merged
fix(build): auto-stamp changelog version from release manifest#1179
Conversation
Read the version from .release-please-manifest.json and pass it to git-cliff via --tag so the root CHANGELOG.md renders the actual version heading instead of [Unreleased]. Closes #987 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (7)
Players (3)
Skins (17)
UI Components (22)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (6)
Skins (14)
UI Components (19)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (8)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.release-please-manifest.jsonand passes it to git-cliff via--tagin the release PR workflowCHANGELOG.mdnow renders## [@videojs/core@X.Y.Z] - DATEinstead of## [Unreleased]How it works
The
release-please--branches--mainbranch already has the bumped version in the manifest whenrelease-pr.ymlruns. We just weren't using it. Now we readpackages/corefrom the manifest and pass--tag @videojs/core@{version}to git-cliff so it stamps the heading correctly.Test plan
--tag) and verify the root CHANGELOG.md no longer has[Unreleased]Closes #987
🤖 Generated with Claude Code
Note
Medium Risk
Touches the release PR GitHub Actions workflow and changelog generation; a wrong manifest lookup or tag format could cause incorrect/missing changelog headings in automated releases.
Overview
The
release-pr.ymlworkflow now reads the currentpackages/coreversion from.github/release-please/.release-please-manifest.jsonand passes it togit-cliffvia--tag, so the generated rootCHANGELOG.mdis stamped with the release version instead of[Unreleased].This wires the manifest-derived tag through a new step output (
steps.version.outputs.tag) without changing the downstream site extraction/commit steps, other than ensuring they see versioned headings.Written by Cursor Bugbot for commit 673cf22. This will update automatically on new commits. Configure here.