fix(html): include base and shared styles in ejected skin CSS#1196
Merged
fix(html): include base and shared styles in ejected skin CSS#1196
Conversation
The ejected HTML player CSS was missing `base.css` and `shared.css` which are normally applied programmatically by `SkinElement`. Without these, the ejected output had broken poster sizing, missing slider dimensions, and the video not filling its container. Closes #1186 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (7)
Players (3)
Skins (17)
UI Components (22)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (6)
Skins (14)
UI Components (19)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (8)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
base.cssandshared.cssin the 4 HTML skin CSS entry points so the ejected player CSS contains the foundational styles that are normally applied programmatically bySkinElementContext
The ejected HTML copies from the homepage/docs produce a broken player because the CSS is missing critical rules:
base.css—video-player { display: contents }andvideo-player video { width/height: 100% }(normally injected intodocument.headbySkinElementviaensureGlobalStyle())shared.css—media-tooltip-group { display: contents }and volume popover hiding (normally applied to shadow DOM viaadoptedStyleSheets)In the ejected flow there is no
<video-skin>element, soSkinElementis never instantiated and these styles are never applied. This caused poster bleed, broken slider/time sizing, and video not filling its container.The fix adds
@import "../base.css"and@import "../shared.css"to each skin CSS entry point. The ejected build'sresolveImports()already handles relative imports, so no build script changes were needed.Closes #1186
Note
Low Risk
Low risk CSS-only change that alters which global/shared rules are included in the four skin entrypoints; main concern is potential minor styling differences for consumers relying on previous missing defaults.
Overview
Ensures the ejected HTML player skins include foundational CSS by importing
base.cssandshared.cssinto the four skin entrypoints (audio/video,default/minimal).This makes builds that resolve CSS imports ship the same base/shared rules that were previously applied programmatically, preventing missing-layout styling when using the standalone skin CSS.
Written by Cursor Bugbot for commit c7332c4. This will update automatically on new commits. Configure here.