Skip to content

fix(html): create HotkeyRegistryController once in connectedCallback#1240

Merged
mihar-22 merged 1 commit intomainfrom
t3code/f9e2a173
Apr 7, 2026
Merged

fix(html): create HotkeyRegistryController once in connectedCallback#1240
mihar-22 merged 1 commit intomainfrom
t3code/f9e2a173

Conversation

@mihar-22
Copy link
Copy Markdown
Member

@mihar-22 mihar-22 commented Apr 7, 2026

Controller was instantiated in connectedCallback without a guard, creating a new instance on every reconnection. Now guarded to create once on first connection.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit b2d3236
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69d4c2536a339b0008a2ff0b
😎 Deploy Preview https://deploy-preview-1240--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Apr 7, 2026 8:37am

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Size
/video (default) 25.17 kB
/video (default + hls) 157.13 kB
/video (minimal) 25.11 kB
/video (minimal + hls) 157.13 kB
/audio (default) 23.26 kB
/audio (minimal) 23.27 kB
/background 6.95 kB
Media (7)
Entry Size
/media/background-video 1.04 kB
/media/container 1.59 kB
/media/dash-video 236.26 kB
/media/hls-video 133.40 kB
/media/mux-video 156.10 kB
/media/native-hls-video 3.54 kB
/media/simple-hls-video 15.06 kB
Players (3)
Entry Size
/video/player 6.66 kB
/audio/player 6.65 kB
/background/player 6.65 kB
Skins (17)
Entry Type Size
/video/minimal-skin.css css 3.42 kB
/video/skin.css css 3.44 kB
/video/minimal-skin js 25.10 kB
/video/minimal-skin.tailwind js 25.41 kB
/video/skin js 25.16 kB
/video/skin.tailwind js 25.54 kB
/audio/minimal-skin.css css 2.48 kB
/audio/skin.css css 2.45 kB
/audio/minimal-skin js 23.27 kB
/audio/minimal-skin.tailwind js 23.50 kB
/audio/skin js 23.26 kB
/audio/skin.tailwind js 23.60 kB
/background/skin.css css 117 B
/background/skin js 1.14 kB
/base.css css 157 B
/shared.css css 88 B
/skin-element js 1.35 kB
UI Components (23)
Entry Size
/ui/alert-dialog 2.21 kB
/ui/alert-dialog-close 1.65 kB
/ui/alert-dialog-description 1.61 kB
/ui/alert-dialog-title 1.61 kB
/ui/buffering-indicator 1.85 kB
/ui/captions-button 1.99 kB
/ui/controls 1.92 kB
/ui/error-dialog 2.38 kB
/ui/fullscreen-button 1.98 kB
/ui/hotkey 1.35 kB
/ui/mute-button 1.97 kB
/ui/pip-button 2.00 kB
/ui/play-button 1.99 kB
/ui/playback-rate-button 2.00 kB
/ui/popover 2.39 kB
/ui/poster 1.79 kB
/ui/seek-button 2.02 kB
/ui/slider 1.67 kB
/ui/thumbnail 2.19 kB
/ui/time 1.71 kB
/ui/time-slider 2.06 kB
/ui/tooltip 2.54 kB
/ui/volume-slider 2.44 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react — no changes
Presets (7)
Entry Size
/video (default) 20.01 kB
/video (default + hls) 151.98 kB
/video (minimal) 20.05 kB
/video (minimal + hls) 152.13 kB
/audio (default) 16.82 kB
/audio (minimal) 16.87 kB
/background 3.16 kB
Media (6)
Entry Size
/media/background-video 476 B
/media/dash-video 236.38 kB
/media/hls-video 133.35 kB
/media/mux-video 156.26 kB
/media/native-hls-video 3.50 kB
/media/simple-hls-video 14.98 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 3.35 kB
/video/skin.css css 3.37 kB
/video/minimal-skin js 19.97 kB
/video/minimal-skin.tailwind js 23.41 kB
/video/skin js 19.93 kB
/video/skin.tailwind js 23.47 kB
/audio/minimal-skin.css css 2.38 kB
/audio/skin.css css 2.34 kB
/audio/minimal-skin js 16.80 kB
/audio/minimal-skin.tailwind js 19.30 kB
/audio/skin js 16.75 kB
/audio/skin.tailwind js 19.28 kB
/background/skin.css css 90 B
/background/skin js 272 B
UI Components (19)
Entry Size
/ui/alert-dialog 1.96 kB
/ui/buffering-indicator 1.74 kB
/ui/captions-button 1.84 kB
/ui/controls 1.70 kB
/ui/error-dialog 2.08 kB
/ui/fullscreen-button 1.83 kB
/ui/mute-button 1.81 kB
/ui/pip-button 1.80 kB
/ui/play-button 1.83 kB
/ui/playback-rate-button 1.88 kB
/ui/popover 3.53 kB
/ui/poster 1.58 kB
/ui/seek-button 1.85 kB
/ui/slider 3.04 kB
/ui/thumbnail 1.90 kB
/ui/time 1.27 kB
/ui/time-slider 3.31 kB
/ui/tooltip 2.82 kB
/ui/volume-slider 3.32 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core — no changes
Entries (8)
Entry Size
. 5.29 kB
/dom 10.44 kB
/dom/media/custom-media-element 1.82 kB
/dom/media/dash 235.76 kB
/dom/media/hls 132.94 kB
/dom/media/mux 155.60 kB
/dom/media/native-hls 2.90 kB
/dom/media/simple-hls 14.45 kB
🏷️ @videojs/element — no changes
Entries (2)
Entry Size
. 999 B
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Size
. 1.39 kB
/html 696 B
/react 360 B
🔧 @videojs/utils — no changes
Entries (10)
Entry Size
/array 104 B
/dom 1.73 kB
/events 319 B
/function 327 B
/object 247 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B
📦 @videojs/spf — no changes
Entries (3)
Entry Size
. 40 B
/dom 12.45 kB
/playback-engine 12.41 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

Creating a new controller in connectedCallback on every reconnection
leaked controllers and context subscriptions. Create it once lazily
in update() with a guard instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mihar-22 mihar-22 changed the title fix(html): lazily create HotkeyRegistryController to prevent leaks fix(html): create HotkeyRegistryController once in connectedCallback Apr 7, 2026
@mihar-22 mihar-22 merged commit 7c63d82 into main Apr 7, 2026
20 of 21 checks passed
@mihar-22 mihar-22 deleted the t3code/f9e2a173 branch April 7, 2026 08:39
This was referenced Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant