Skip to content

fix(core): reduce doubletap window from 300ms to 200ms#1328

Merged
mihar-22 merged 1 commit intomainfrom
fix/tap-delay-1323
Apr 14, 2026
Merged

fix(core): reduce doubletap window from 300ms to 200ms#1328
mihar-22 merged 1 commit intomainfrom
fix/tap-delay-1323

Conversation

@mihar-22
Copy link
Copy Markdown
Member

@mihar-22 mihar-22 commented Apr 14, 2026

Closes #1323


Note

Low Risk
Low risk: a small timing-tweak in gesture recognition plus test updates, with no security or data handling impact. Main risk is subtle UX/regression for users who double-tap more slowly.

Overview
Reduces the double-tap recognition window in TapRecognizer from 300ms to 200ms, making double-taps require a tighter second tap.

Updates gesture unit tests to use the new DOUBLETAP_WINDOW so tap/doubletap disambiguation assertions match the revised timing.

Reviewed by Cursor Bugbot for commit 49c792a. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Apr 14, 2026 6:59am

Request Review

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 14, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 49c792a
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69dde5b4028b960008095448
😎 Deploy Preview https://deploy-preview-1328--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Size
/video (default) 27.85 kB
/video (default + hls) 159.96 kB
/video (minimal) 25.36 kB
/video (minimal + hls) 157.45 kB
/audio (default) 25.90 kB
/audio (minimal) 23.54 kB
/background 4.16 kB
Media (8)
Entry Size
/media/background-video 1.04 kB
/media/container 1.73 kB
/media/dash-video 236.38 kB
/media/hls-video 133.38 kB
/media/mux-audio 155.82 kB
/media/mux-video 155.68 kB
/media/native-hls-video 3.45 kB
/media/simple-hls-video 15.72 kB
Players (3)
Entry Size
/video/player 6.73 kB
/audio/player 5.07 kB
/background/player 3.86 kB
Skins (17)
Entry Type Size
/video/minimal-skin.css css 3.47 kB
/video/skin.css css 3.49 kB
/video/minimal-skin js 25.34 kB
/video/minimal-skin.tailwind js 25.57 kB
/video/skin js 27.85 kB
/video/skin.tailwind js 27.95 kB
/audio/minimal-skin.css css 2.53 kB
/audio/skin.css css 2.50 kB
/audio/minimal-skin js 23.48 kB
/audio/minimal-skin.tailwind js 23.67 kB
/audio/skin js 25.91 kB
/audio/skin.tailwind js 25.98 kB
/background/skin.css css 117 B
/background/skin js 1.14 kB
/base.css css 157 B
/shared.css css 88 B
/skin-element js 1.35 kB
UI Components (24)
Entry Size
/ui/alert-dialog 985 B
/ui/alert-dialog-close 449 B
/ui/alert-dialog-description 411 B
/ui/alert-dialog-title 391 B
/ui/buffering-indicator 2.15 kB
/ui/captions-button 2.38 kB
/ui/compounds 3.87 kB
/ui/controls 2.11 kB
/ui/error-dialog 2.53 kB
/ui/fullscreen-button 2.36 kB
/ui/hotkey 1.71 kB
/ui/mute-button 2.40 kB
/ui/pip-button 2.40 kB
/ui/play-button 2.40 kB
/ui/playback-rate-button 2.44 kB
/ui/popover 1.82 kB
/ui/poster 1.97 kB
/ui/seek-button 2.38 kB
/ui/slider 1.47 kB
/ui/thumbnail 2.52 kB
/ui/time 2.22 kB
/ui/time-slider 3.65 kB
/ui/tooltip 1.92 kB
/ui/volume-slider 2.47 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react — no changes
Presets (7)
Entry Size
/video (default) 22.61 kB
/video (default + hls) 153.54 kB
/video (minimal) 20.30 kB
/video (minimal + hls) 151.20 kB
/audio (default) 18.57 kB
/audio (minimal) 17.11 kB
/background 754 B
Media (7)
Entry Size
/media/background-video 575 B
/media/dash-video 234.92 kB
/media/hls-video 132.07 kB
/media/mux-audio 154.66 kB
/media/mux-video 154.65 kB
/media/native-hls-video 1.98 kB
/media/simple-hls-video 14.38 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 3.40 kB
/video/skin.css css 3.42 kB
/video/minimal-skin js 20.24 kB
/video/minimal-skin.tailwind js 23.70 kB
/video/skin js 22.53 kB
/video/skin.tailwind js 23.73 kB
/audio/minimal-skin.css css 2.43 kB
/audio/skin.css css 2.39 kB
/audio/minimal-skin js 17.02 kB
/audio/minimal-skin.tailwind js 19.51 kB
/audio/skin js 18.53 kB
/audio/skin.tailwind js 19.53 kB
/background/skin.css css 90 B
/background/skin js 272 B
UI Components (19)
Entry Size
/ui/alert-dialog 847 B
/ui/buffering-indicator 1.81 kB
/ui/captions-button 2.36 kB
/ui/controls 1.76 kB
/ui/error-dialog 2.38 kB
/ui/fullscreen-button 2.41 kB
/ui/mute-button 2.36 kB
/ui/pip-button 2.37 kB
/ui/play-button 2.40 kB
/ui/playback-rate-button 2.38 kB
/ui/popover 1.53 kB
/ui/poster 1.68 kB
/ui/seek-button 2.38 kB
/ui/slider 3.32 kB
/ui/thumbnail 2.06 kB
/ui/time 1.88 kB
/ui/time-slider 2.87 kB
/ui/tooltip 1.80 kB
/ui/volume-slider 2.87 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core — no changes
Entries (8)
Entry Size
. 4.79 kB
/dom 11.28 kB
/dom/media/custom-media-element 1.92 kB
/dom/media/dash 234.26 kB
/dom/media/hls 131.33 kB
/dom/media/mux 153.97 kB
/dom/media/native-hls 1.24 kB
/dom/media/simple-hls 13.65 kB
🏷️ @videojs/element — no changes
Entries (2)
Entry Size
. 999 B
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Size
. 1.39 kB
/html 695 B
/react 360 B
🔧 @videojs/utils — no changes
Entries (10)
Entry Size
/array 104 B
/dom 1.84 kB
/events 319 B
/function 327 B
/object 275 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B
📦 @videojs/spf — no changes
Entries (3)
Entry Size
. 40 B
/dom 13.34 kB
/playback-engine 13.20 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

Closes #1323

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mihar-22 mihar-22 force-pushed the fix/tap-delay-1323 branch from 76a674b to 49c792a Compare April 14, 2026 06:58
@mihar-22 mihar-22 merged commit 8bce342 into main Apr 14, 2026
23 checks passed
@mihar-22 mihar-22 deleted the fix/tap-delay-1323 branch April 14, 2026 07:05
@luwes luwes mentioned this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Noticeable Delay on Single Tap Play/Pause Gesture

1 participant