Conversation
cjpillsbury
reviewed
Sep 16, 2025
| state: TState | ||
| ) => React.ReactElement; | ||
|
|
||
| const Context = React.createContext<any | null>(null); |
Collaborator
There was a problem hiding this comment.
non-blocking: If there's an easy way to make this optional, that would be 👌. Feel free to e.g. change the args into an "options-style object" if that makes things easier.
Collaborator
Author
There was a problem hiding this comment.
cool yes, that a nice optimization. I'll leave it for a next iteration.
cjpillsbury
reviewed
Sep 16, 2025
|
|
||
| export const useTimeRangeTrackProps = (props: React.PropsWithChildren<{ [k: string]: any }>) => { | ||
| const { setTrackRef } = useTimeRangeRootContext(); | ||
| export const useTimeRangeTrackProps = (props: React.PropsWithChildren<{ [k: string]: any }>, context: any) => { |
Collaborator
There was a problem hiding this comment.
question(non-blocking) - is this "context" or the context's "value"?
Collaborator
Author
There was a problem hiding this comment.
the context value
const context = React.useContext(Context);
bad naming on my part
luwes
changed the title
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.