Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the React Popover component to use the Core Popover component instead of maintaining duplicate implementation logic. The changes consolidate hover behavior, transition handling, and positioning logic into the core package while the React component now acts as a thin wrapper.
Key changes:
- React Popover now imports and delegates to
@videojs/corePopover component - Renamed
opento_openin core state to indicate internal usage - Wrapped
hidePopover()call inrequestAnimationFramefor proper animation timing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/components/Popover.tsx | Refactored to use component factory pattern with Core Popover, removing ~150 lines of duplicate hover/positioning logic |
| packages/html/src/elements/popover.ts | Exported PopoverState type for external usage |
| packages/core/src/components/popover.ts | Renamed open to _open and added requestAnimationFrame wrapper for hidePopover transitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the React Popover component use the Core component removing duplicated code.