Merged
Conversation
2f07360 to
9036e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this adds an ESLint config using Antfu's config.
Obviously we can tweak rules as we go but I find the defaults a pretty much "best practice".
Initial run of the lint task came up with a few things to fix:
Enabling it
I've not enabled any automatic stuff yet but I guess we'll want to at a suitable time. This would require changing
.vscode/settings.jsonfrom:{ // At some point, we'll watch to flick this on and uncomment lines 5 & 6 below. "eslint.enable": false, // Disable the default formatter, use eslint instead // "prettier.enable": false, // "editor.formatOnSave": false, }to:
{ // Disable the default formatter, use eslint instead "prettier.enable": false, "editor.formatOnSave": false, }and in
package.jsonfor the git hooks, by uncommenting:preparescript (which will add the git hooks)simple-git-hookssection (which allows us to hook into a commit)lint-stagedsection (which allows fixing issues at the staging step of the commit).