Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses on improving developer experience, fixing TypeScript configuration issues, and establishing consistent patterns across the monorepo.
TypeScript & Typecheck Fixes
tsconfig.json: Added proper project references for all subpath exports (utils/dom,store/dom,store/lit,store/react,core/dom) to enablepnpm typecheckto work correctly across the entire repoemitDeclarationOnly: truetotsconfig.base.jsonfor cleaner type generationtypes/directory from compilation to avoid conflictstsconfig.build.jsonfiles from packages (utils, store, core, html, react) - build config now handled by tsdownCLAUDE.md Improvements
packages/__tech-preview__/(legacy Demuxed demo code)pnpm typecheck)Consistent Test Directory Structure
Moved all test files into
tests/directories next to the code they test:utils package:
src/dom/*.test.ts→src/dom/tests/*.test.tssrc/*.test.ts→src/events/tests/*.test.ts,src/predicate/tests/*.test.tsstore package:
test/*.test.ts→src/core/tests/*.test.tstest/dom/*.test.ts→src/dom/tests/*.test.tsUtils Package Exports Reorganization
Restructured exports into logical subpaths:
@videojs/utils/events-disposer,event-likeutilities@videojs/utils/predicate- type predicate utilities@videojs/utils/object- NEW:pickandselectorutilities@videojs/utils/types- NEW: shared type definitionsStore Core Type Improvements
Queuetypes: Better generic type inference for queued operationsRequesttypes: Cleaner async request handling typesSlicetypes: More precise selector and action typesStoretypes: Better type safety for store compositionGuardtypes: Enhanced type narrowing for state guardsClaude Agent Updates
docs.mdagent for documentation tasksdx-reviewer.mdwith comprehensivedx.mdagent