Skip to content

chore: workspace improvements#282

Merged
mihar-22 merged 11 commits intomainfrom
workspace
Jan 3, 2026
Merged

chore: workspace improvements#282
mihar-22 merged 11 commits intomainfrom
workspace

Conversation

@mihar-22
Copy link
Copy Markdown
Member

@mihar-22 mihar-22 commented Jan 3, 2026

Summary

This PR focuses on improving developer experience, fixing TypeScript configuration issues, and establishing consistent patterns across the monorepo.

TypeScript & Typecheck Fixes

  • Fixed root tsconfig.json: Added proper project references for all subpath exports (utils/dom, store/dom, store/lit, store/react, core/dom) to enable pnpm typecheck to work correctly across the entire repo
  • Added emitDeclarationOnly: true to tsconfig.base.json for cleaner type generation
  • Excluded types/ directory from compilation to avoid conflicts
  • Removed obsolete tsconfig.build.json files from packages (utils, store, core, html, react) - build config now handled by tsdown

CLAUDE.md Improvements

  • Added note to ignore packages/__tech-preview__/ (legacy Demuxed demo code)
  • Expanded common commands with more detailed examples:
    • Typecheck command (pnpm typecheck)
    • Package-specific test commands with patterns and file filters
    • Single file lint fix command
  • Added Dev Workflow section with clear step-by-step process
  • Added Testing section with file organization conventions and test patterns
  • Simplified guidelines by removing redundant sections

Consistent Test Directory Structure

Moved all test files into tests/ directories next to the code they test:

utils package:

  • src/dom/*.test.tssrc/dom/tests/*.test.ts
  • src/*.test.tssrc/events/tests/*.test.ts, src/predicate/tests/*.test.ts

store package:

  • test/*.test.tssrc/core/tests/*.test.ts
  • test/dom/*.test.tssrc/dom/tests/*.test.ts

Utils Package Exports Reorganization

Restructured exports into logical subpaths:

  • @videojs/utils/events - disposer, event-like utilities
  • @videojs/utils/predicate - type predicate utilities
  • @videojs/utils/object - NEW: pick and selector utilities
  • @videojs/utils/types - NEW: shared type definitions

Store Core Type Improvements

  • Enhanced Queue types: Better generic type inference for queued operations
  • Improved Request types: Cleaner async request handling types
  • Refined Slice types: More precise selector and action types
  • Strengthened Store types: Better type safety for store composition
  • Improved Guard types: Enhanced type narrowing for state guards
  • Added comprehensive tests for queue operations

Claude Agent Updates

  • Added docs.md agent for documentation tasks
  • Replaced dx-reviewer.md with comprehensive dx.md agent

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
vjs-10-demo-html Ready Ready Preview, Comment Jan 3, 2026 2:38pm
vjs-10-demo-next Ready Ready Preview, Comment Jan 3, 2026 2:38pm
vjs-10-demo-react Ready Ready Preview, Comment Jan 3, 2026 2:38pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
vjs-10-website Skipped Skipped Jan 3, 2026 2:38pm

@mihar-22 mihar-22 changed the title chore: fix typecheck, improve docs, standardize test dirs, and enhance types chore: workspace improvements Jan 3, 2026
@vercel vercel bot temporarily deployed to Preview – vjs-10-website January 3, 2026 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vjs-10-demo-html January 3, 2026 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vjs-10-demo-react January 3, 2026 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vjs-10-demo-next January 3, 2026 14:38 Inactive
@mihar-22 mihar-22 merged commit 2901593 into main Jan 3, 2026
7 checks passed
@mihar-22 mihar-22 deleted the workspace branch January 3, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant