feat: add HTML vertical orientation to time and volume#32
Merged
Conversation
range components
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds vertical orientation support to HTML media time and volume range components. The implementation allows range sliders to be displayed vertically instead of the default horizontal orientation.
- Adds CSS styles for both horizontal and vertical orientations with appropriate positioning and dimensions
- Implements orientation attribute handling and state management in component classes
- Updates component positioning logic to support vertical layout with proper thumb and progress positioning
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| media-skin-default.ts | Adds CSS styles for horizontal/vertical orientations and sets volume range to vertical by default |
| media-volume-range.ts | Implements orientation attribute support with dynamic styling and positioning logic |
| media-time-range.ts | Implements orientation attribute support with dynamic styling and positioning logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| media-time-range-root { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; |
There was a problem hiding this comment.
Adding justify-content: center to the base styles may affect existing horizontal layouts. Consider moving this property to the orientation-specific selectors to avoid unintended changes to the default behavior.
luwes
changed the title
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the vertical orientation to the HTML ranges