refactor(store): simplify controller and state APIs#352
Merged
Conversation
- Create SubscriptionController as shared base for Lit controllers - QueueController/StoreController are now thin wrappers over SubscriptionController - SubscriptionController implements ReactiveController and handles lifecycle - Simplify StateChange callback signature (no longer passes changedKeys) - Add useMemo to React hooks for stable object references - Remove unused extendConfig utility - Update tests to use real Lit lifecycle (appendChild/remove)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the store package APIs by creating a shared
SubscriptionControllerbase for Lit controllers and removing unused utilities.Changes
SubscriptionControlleras shared base that handles store resolution (direct or context) and subscription lifecycleQueueControllerandStoreControllerare now thin wrappers that configure what to subscribe toSubscriptionControllerimplementsReactiveControllerand registers itself with the hostStateChangecallback signature — no longer passeschangedKeysto callbacks (internal tracking preserved)useMemoto React hooks for stable object referencesextendConfigutility and testsImplementation details
Controller hierarchy:
Test improvements:
TestHostElement extends ReactiveElementappendChild/remove) instead of simulatinghostConnected/hostDisconnectedTesting
pnpm -F @videojs/store test— 238 tests pass