refactor(store): simplify queue - remove task state tracking#359
Merged
refactor(store): simplify queue - remove task state tracking#359
Conversation
BREAKING CHANGE: Queue no longer tracks task state (pending/success/error). - Remove task.ts and all task state types - Remove queue.tasks, queue.subscribe, queue.reset - Remove store.queue getter (queue is now internal) - Remove guard combinators (all, any, timeout) - Keep only: queue.enqueue, queue.abort, queue.destroy - Wrap handlers with abortable() for consistent abort behavior
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This was referenced Jan 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of Store v2: Simplify the queue by removing task state tracking.
task.tsand all task state types (PendingTask,SuccessTask,ErrorTask)queue.tasks,queue.subscribe,queue.resetstore.queuegetter (queue is now internal)all,any,timeout) - keep onlyGuardtypequeue.enqueue,queue.abort,queue.destroyabortable()for consistent abort behaviorBreaking Changes
store.queueno longer exposedQueueno longer generic, no longer tracks task stateInferStoreTasks,UnionFeatureTasks,TasksRecordtypes removedNotes
This PR intentionally leaves Lit/React platform bindings broken - they still reference removed types (
store.queue,TasksRecord, etc.). Those will be fixed in Phase 2 (PR 2: Remove Platform Queue Bindings).Test Plan
pnpm -F @videojs/store test src/core- 115 tests passpnpm lint- no issuespnpm -F @videojs/store build- succeeds (warnings expected for broken bindings)