Conversation
- Core logic class with state derivation (muted, volumeLevel) - HTML custom element (MuteButtonElement) - React component with render prop support - Enhanced state-data-attrs with explicit attribute mapping - Convert PlayButtonDataAttrs from enum to const object Closes #268
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
❌ Deploy Preview for vjs10-site failed. Why did it fail? →
|
- Move logMissingFeature from update() to connectedCallback()
- Support function labels: label={(state) => state.paused ? 'Start' : 'Stop'}
- Add tests for function label behavior
mihar-22
changed the title
mihar-22
changed the title
Closed
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268
Summary
Implement the MuteButton component for toggling media mute state. Includes core interaction logic, data attributes for styling, and platform implementations for HTML custom elements and React. Also aligns PlayButton API for consistency.
Changes
MuteButtonCoreclass with state derivation (muted,volumeLevellevels: off/low/medium/high)MuteButtonElementcustom element with Lit reactive propertiesMuteButtoncomponent with render prop support and ref forwardingstate-data-attrsutilities to support explicit attribute mapping (e.g.,data-volume-levelinstead ofdata-volumelevel)stateAttrMapparameter to React'srenderElementfor consistent attribute namingPlayButtonDataAttrsfrom enum to const object for consistencyPlayButton alignment
logMissingFeaturefromupdate()toconnectedCallback()for consistencylabel={(state) => state.paused ? 'Start' : 'Stop'}Testing