Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
heff
left a comment
heff
left a comment
There was a problem hiding this comment.
issue(blocking): After a first pass I think we should talk through this IRL.
- The relationship between the components is confusing me
- It's downplaying "control bar" and making it generic, which feels like a miss to me
I also want to make sure we're on the same page about default behaviors here, for example in MC everything that's a child of the Container gets hidden by default, and it's handled as more like a layer. This design reads like it assumes we're only thinking about the control bar hiding, and not other elements like a title (top left) and share buttons (top right), which should all be hidden at the same time and with the same delay.
|
Sounds good @heff, let's chat IRL :) This one does have some annoying details for us to align on. |
mihar-22
changed the title
…trols - Remove hide-delay attribute from media-controls component API - Remove hideDelay prop from React Controls.Root examples - Remove setUserIdleTimeout from feature state interface - Remove Container Integration section (data-user-active, data-controls-visible) - Remove cursor-hiding CSS referencing container data-attrs - Remove related decision sections (hide-delay placement, milliseconds, opt-out) - Reassign auto-hide timing responsibility to controlsFeature in solution table
2 participants
ref: #237
Summary
Design document for the Controls component and
controlsFeaturefor Video.js 10.<media-controls>and<media-controls-group>componentsuserActive,controlsVisible,setUserIdleTimeout)role="group"), default styles, and behaviorReferences