refactor(packages): derive default props from core classes#488
Merged
refactor(packages): derive default props from core classes#488
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTML and React components were hardcoding their own default prop values (
label = '',disabled = false, etc.) instead of deriving them from core. This establishes core as the single source of truth for all component default props.Changes
Core.defaultProps.*in class field initializers instead of hardcoded valuesundefinedflow tocore.setProps()wheredefaults()resolves themTime.ValueusesTimeCore.defaultProps.negativeSignas the fallback for the render-specificnegativeSignpropTesting
Covered by existing tests.
pnpm -F @videojs/core test && pnpm -F @videojs/html test && pnpm -F @videojs/react test