Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report
Total: 23.54 kB · +278 B · +1.2% Entry BreakdownSubpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.
|
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.32 kB | 1.39 kB | +77 B | +5.7% | 🔺 |
./dom |
2.68 kB | 2.68 kB | 0 B | 0% | ✅ |
| total | 4.00 kB | 4.08 kB | +77 B | +1.9% |
@videojs/element
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
817 B | 817 B | 0 B | 0% | ✅ |
./context |
823 B | 823 B | 0 B | 0% | ✅ |
| total | 1.60 kB | 1.60 kB | 0 B | 0% |
@videojs/store
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.29 kB | 1.29 kB | 0 B | 0% | ✅ |
./html |
394 B | 394 B | 0 B | 0% | ✅ |
./react |
190 B | 190 B | 0 B | 0% | ✅ |
| total | 1.86 kB | 1.86 kB | 0 B | 0% |
@videojs/utils
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
./array |
104 B | 104 B | 0 B | 0% | ✅ |
./dom |
553 B | 553 B | 0 B | 0% | ✅ |
./events |
227 B | 227 B | 0 B | 0% | ✅ |
./function |
181 B | 181 B | 0 B | 0% | ✅ |
./object |
119 B | 119 B | 0 B | 0% | ✅ |
./predicate |
265 B | 265 B | 0 B | 0% | ✅ |
./time |
465 B | 465 B | 0 B | 0% | ✅ |
| total | 1.87 kB | 1.87 kB | 0 B | 0% |
ℹ️ How to interpret
Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.
| Icon | Meaning |
|---|---|
| ✅ | No change |
| 🔺 | Increased ≤ 10% |
| 🔴 | Increased > 10% |
| 🔽 | Decreased |
| 🆕 | New (no baseline) |
Run pnpm size locally to check current sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
Summary
Add PiP (picture-in-picture) button component for toggling video PiP mode. Includes core interaction logic, HTML custom element, and React component — following the same three-layer architecture as the existing fullscreen button.
Changes
PiPButtonCorewith props, state projection, label resolution, ARIA attrs, and async toggle with availability guardPiPButtonDataAttrsexposingdata-pipanddata-availabilityfor CSS stylingPiPButtonElementcustom element (<media-pip-button>) wired to the player store viaselectPiPPiPButtonReact component withforwardRef, render prop support, and state-driven data attributesImplementation details
This only covers standard Video PiP (
HTMLVideoElement.requestPictureInPicture). Document PiP (the newerdocumentPictureInPicture.requestWindow()API) is deferred to a follow-up — the button callsrequestPiP()/exitPiP()from the store, so it will work with Document PiP when that's added to the store layer without any button changes.Testing
pnpm -F @videojs/core test src/core/ui/pip-buttonAll 13 tests pass. Full build and typecheck clean.