Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📦 Bundle Size Report
Total: 24.01 kB · +482 B · +2.0% Entry BreakdownSubpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.
|
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.39 kB | 1.52 kB | +131 B | +9.2% | 🔺 |
./dom |
2.68 kB | 2.67 kB | -9 B | -0.3% | 🔽 |
| total | 4.08 kB | 4.20 kB | +122 B | +2.9% |
@videojs/element
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
817 B | 817 B | 0 B | 0% | ✅ |
./context |
823 B | 823 B | 0 B | 0% | ✅ |
| total | 1.60 kB | 1.60 kB | 0 B | 0% |
@videojs/store
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.29 kB | 1.29 kB | 0 B | 0% | ✅ |
./html |
394 B | 394 B | 0 B | 0% | ✅ |
./react |
190 B | 190 B | 0 B | 0% | ✅ |
| total | 1.86 kB | 1.86 kB | 0 B | 0% |
@videojs/utils
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
./array |
104 B | 104 B | 0 B | 0% | ✅ |
./dom |
553 B | 553 B | 0 B | 0% | ✅ |
./events |
227 B | 227 B | 0 B | 0% | ✅ |
./function |
181 B | 181 B | 0 B | 0% | ✅ |
./object |
119 B | 119 B | 0 B | 0% | ✅ |
./predicate |
265 B | 265 B | 0 B | 0% | ✅ |
./time |
465 B | 465 B | 0 B | 0% | ✅ |
| total | 1.87 kB | 1.87 kB | 0 B | 0% |
ℹ️ How to interpret
Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.
| Icon | Meaning |
|---|---|
| ✅ | No change |
| 🔺 | Increased ≤ 10% |
| 🔴 | Increased > 10% |
| 🔽 | Decreased |
| 🆕 | New (no baseline) |
Run pnpm size locally to check current sizes.
50bb5bc to
96b417c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #495
Summary
Add SeekButton component for seeking forward/backward by a configurable number of seconds. Follows the same three-layer pattern as PlayButton (Core + HTML + React) with a single
secondsprop that supports positive (forward) and negative (backward) values.Changes
SeekButtonCoreclass withsecondsprop (default 30), label generation usingMath.absto avoid negative signs in accessibility labelsSeekButtonDataAttrsmappingseekingandsecondsto data attributes for CSS-driven styling<media-seek-button>custom element withseconds,label, anddisabledattributes, usingselectTimeselector<SeekButton>React component withrenderprop support, matching existing button patternsImplementation details
Design decision: Single component vs two. Unlike Media Chrome (separate forward/backward elements), this uses Vidstack's approach — one component where the sign of
secondscommunicates direction. Avoids ~95% code duplication whiledata-secondsenables CSS targeting via[data-seconds^="-"].No clamping in the button. The store's
timeFeature.seek()already clamps to[0, duration], so the button just computescurrentTime + secondsand delegates.Default 30s matches both Vidstack and Media Chrome industry defaults.
Testing
pnpm -F @videojs/core test src/core/ui/seek-buttonAll workspace tests pass:
pnpm test(12 tasks, 244+ tests).