feat(store): state subscription primitives#528
Merged
Conversation
Add State<T> subscription primitives for React and HTML platforms, and expose the store's internal State container via $state for composition. - identity() utility in @videojs/utils/function - useSnapshot React hook with optional selector and custom comparator - SnapshotController for HTML elements with selector, shallowEqual, and track() - StoreController refactored to compose SnapshotController internally - store.$state exposes read-only State<T> container on BaseStore
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report
Total: 24.20 kB · +195 B · +0.8% Entry BreakdownSubpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.
|
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.52 kB | 1.52 kB | 0 B | 0% | ✅ |
./dom |
2.67 kB | 2.68 kB | +4 B | +0.1% | 🔺 |
| total | 4.20 kB | 4.20 kB | +4 B | +0.1% |
@videojs/element
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
817 B | 817 B | 0 B | 0% | ✅ |
./context |
823 B | 823 B | 0 B | 0% | ✅ |
| total | 1.60 kB | 1.60 kB | 0 B | 0% |
@videojs/store
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.29 kB | 1.29 kB | +1 B | +0.1% | 🔺 |
./html |
394 B | 468 B | +74 B | +18.8% | 🔴 |
./react |
190 B | 199 B | +9 B | +4.7% | 🔺 |
| total | 1.86 kB | 1.94 kB | +84 B | +4.4% |
@videojs/utils
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
./array |
104 B | 104 B | 0 B | 0% | ✅ |
./dom |
553 B | 553 B | 0 B | 0% | ✅ |
./events |
227 B | 227 B | 0 B | 0% | ✅ |
./function |
181 B | 197 B | +16 B | +8.8% | 🔺 |
./object |
119 B | 119 B | 0 B | 0% | ✅ |
./predicate |
265 B | 265 B | 0 B | 0% | ✅ |
./time |
465 B | 465 B | 0 B | 0% | ✅ |
| total | 1.87 kB | 1.88 kB | +16 B | +0.8% |
ℹ️ How to interpret
Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.
| Icon | Meaning |
|---|---|
| ✅ | No change |
| 🔺 | Increased ≤ 10% |
| 🔴 | Increased > 10% |
| 🔽 | Decreased |
| 🆕 | New (no baseline) |
Run pnpm size locally to check current sizes.
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
State<T>subscription primitives for both React and HTML platforms, preparing the foundation for slider components that need to subscribe to local state containers (not just stores).Changes
identity()utility — Generic identity function in@videojs/utils/function, replaces inline(s: any) => sand(s) => s as unknown as RpatternsuseSnapshotReact hook — Subscribe to aState<T>container with optional selector and custom comparator, built onuseSelectorSnapshotController— HTML reactive controller forState<T>with optional selector,shallowEqualdiffing, andtrack()to switch state containersstore.$state— Expose the store's internalState<T>container (read-only) onBaseStore, enablingSnapshotControllercompositionStoreControllerrefactored — Now composesSnapshotControllerinternally viastore.$stateinstead of duplicating selector/shallowEqual logicImplementation details
SnapshotControllersupports two modes: without selector (re-renders on any state change) and with selector (re-renders only when the selected slice changes viashallowEqual). Thetrack()method allows switching to a differentState<T>container, whichStoreControlleruses when the store reconnects.useStorecannot composeuseSnapshotdue to React's rules of hooks — the no-selector mode (returns store, no subscription) and selector mode (subscribes to state) require different hook call patterns that can't be conditional.Testing