Skip to content

docs(design): add player-container separation decision#614

Merged
heff merged 4 commits intomainfrom
design/player-container-separation
Feb 26, 2026
Merged

docs(design): add player-container separation decision#614
heff merged 4 commits intomainfrom
design/player-container-separation

Conversation

@heff
Copy link
Copy Markdown
Member

@heff heff commented Feb 26, 2026

Summary

Documents the decision to keep <video-player> as a provider-only element with a separate <media-container> for layout, media attachment, and fullscreen — mirroring the React architecture where Provider, Container, and media components are distinct.

Changes

  • Formalizes player-container separation as the default HTML architecture
  • Explains cross-platform skin parity rationale (skins mean the same thing on React and HTML)
  • Documents how separated provider enables extended player applications (playlist, transcript, sidebar outside fullscreen target)
  • Notes the trade-off of ergonomic friction with nested elements and display: contents

Testing

Documentation only — no code changes.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
vjs-10-demo-react Ignored Ignored Preview Feb 26, 2026 0:14am

Request Review

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 26, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 2382a54
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/699f907969d37b00087bd30a
😎 Deploy Preview https://deploy-preview-614--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2026

📦 Bundle Size Report

Package Size Diff %
@videojs/core 6.61 kB 0 B ░░░░░░░░ 0%
@videojs/element 1.60 kB 0 B ░░░░░░░░ 0%
@videojs/html 9.45 kB 0 B ░░░░░░░░ 0%
@videojs/icons 3.79 kB 0 B ░░░░░░░░ 0%
@videojs/react 16.27 kB 0 B ░░░░░░░░ 0%
@videojs/store 1.94 kB 0 B ░░░░░░░░ 0%
@videojs/utils 2.47 kB 0 B ░░░░░░░░ 0%

Total: 42.12 kB · 0 B · 0%


Entry Breakdown

Subpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.

@videojs/core
Entry Base PR Diff %
. 3.10 kB 3.10 kB 0 B 0%
./dom 3.50 kB 3.50 kB 0 B 0%
total 6.61 kB 6.61 kB 0 B 0%
@videojs/element
Entry Base PR Diff %
. 817 B 817 B 0 B 0%
./context 823 B 823 B 0 B 0%
total 1.60 kB 1.60 kB 0 B 0%
@videojs/icons
Entry Base PR Diff %
./react 2.27 kB 2.27 kB 0 B 0%
./html 1.52 kB 1.52 kB 0 B 0%
total 3.79 kB 3.79 kB 0 B 0%
@videojs/react
Entry Base PR Diff %
. 8.50 kB 8.50 kB 0 B 0%
./audio 238 B 238 B 0 B 0%
./background 302 B 302 B 0 B 0%
./video 7.24 kB 7.24 kB 0 B 0%
total 16.27 kB 16.27 kB 0 B 0%
@videojs/store
Entry Base PR Diff %
. 1.29 kB 1.29 kB 0 B 0%
./html 468 B 468 B 0 B 0%
./react 199 B 199 B 0 B 0%
total 1.94 kB 1.94 kB 0 B 0%
@videojs/utils
Entry Base PR Diff %
./array 104 B 104 B 0 B 0%
./dom 684 B 684 B 0 B 0%
./events 227 B 227 B 0 B 0%
./function 197 B 197 B 0 B 0%
./object 119 B 119 B 0 B 0%
./predicate 265 B 265 B 0 B 0%
./string 110 B 110 B 0 B 0%
./style 185 B 185 B 0 B 0%
./time 478 B 478 B 0 B 0%
./number 158 B 158 B 0 B 0%
total 2.47 kB 2.47 kB 0 B 0%

ℹ️ How to interpret

Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

Comment thread internal/decisions/player-container-separation.md
@heff heff merged commit 897a5af into main Feb 26, 2026
12 checks passed
@heff heff deleted the design/player-container-separation branch February 26, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants