Skip to content

feat(html): add volume slider element#657

Merged
mihar-22 merged 1 commit intomainfrom
feat/html-volume-slider
Mar 1, 2026
Merged

feat(html): add volume slider element#657
mihar-22 merged 1 commit intomainfrom
feat/html-volume-slider

Conversation

@mihar-22
Copy link
Copy Markdown
Member

@mihar-22 mihar-22 commented Mar 1, 2026

Refs #269

Stacked on #656

Summary

Volume slider element connecting to the player store for volume control.

API Surface

Element: <media-volume-slider> — extends slider with VolumeSliderCore, vertical orientation support, percentage formatting

Properties: label, disabled, thumbAlignment, orientation

Testing

pnpm -F @videojs/html test src/ui/volume-slider — 7 tests

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
vjs-10-demo-react Ignored Ignored Preview Mar 1, 2026 5:08am

Request Review

@mihar-22 mihar-22 force-pushed the feat/html-volume-slider branch 2 times, most recently from ec588d4 to 120caad Compare March 1, 2026 02:35
@mihar-22 mihar-22 force-pushed the feat/html-time-slider branch from 5fd6a44 to cc05b0e Compare March 1, 2026 02:35
@mihar-22 mihar-22 force-pushed the feat/html-volume-slider branch from 120caad to b28f85c Compare March 1, 2026 02:37
@mihar-22 mihar-22 force-pushed the feat/html-time-slider branch from cc05b0e to 9eee94c Compare March 1, 2026 02:37
@mihar-22 mihar-22 force-pushed the feat/html-volume-slider branch from b28f85c to b56b367 Compare March 1, 2026 02:38
@mihar-22 mihar-22 force-pushed the feat/html-time-slider branch 2 times, most recently from 0c7e3ad to 94c6830 Compare March 1, 2026 04:09
@mihar-22 mihar-22 force-pushed the feat/html-volume-slider branch 2 times, most recently from 8d33c1d to 507530b Compare March 1, 2026 04:16
@mihar-22 mihar-22 force-pushed the feat/html-time-slider branch from 94c6830 to d4e9616 Compare March 1, 2026 04:16
Base automatically changed from feat/html-time-slider to main March 1, 2026 04:52
@mihar-22 mihar-22 force-pushed the feat/html-volume-slider branch from 507530b to ba0b1eb Compare March 1, 2026 04:53
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 1, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 1701426
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69a3c9bb508cf40008449624
😎 Deploy Preview https://deploy-preview-657--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2026

📦 Bundle Size Report

Package Size Diff %
@videojs/core 10.28 kB +14 B ██░░░░░░ +0.1% 🔺
@videojs/element 1.60 kB 0 B ░░░░░░░░ 0%
@videojs/html 18.36 kB +106 B ████████ +0.6% 🔺
@videojs/icons 3.79 kB 0 B ░░░░░░░░ 0%
@videojs/react 14.90 kB +24 B ██░░░░░░ +0.2% 🔺
@videojs/store 1.95 kB 0 B ░░░░░░░░ 0%
@videojs/utils 2.81 kB 0 B ░░░░░░░░ 0%

Total: 53.68 kB · +144 B · +0.3%


Entry Breakdown

Subpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.

@videojs/core
Entry Base PR Diff %
. 4.25 kB 4.28 kB +27 B +0.6% 🔺
./dom 6.02 kB 6.01 kB -13 B -0.2% 🔽
total 10.27 kB 10.28 kB +14 B +0.1%
@videojs/element
Entry Base PR Diff %
. 817 B 817 B 0 B 0%
./context 823 B 823 B 0 B 0%
total 1.60 kB 1.60 kB 0 B 0%
@videojs/html
Entry Base PR Diff %
. 15.03 kB 15.20 kB +173 B +1.1% 🔺
./video 1.09 kB 1.06 kB -35 B -3.1% 🔽
./audio 1.07 kB 1.06 kB -14 B -1.3% 🔽
./background 1.07 kB 1.05 kB -18 B -1.6% 🔽
total 18.25 kB 18.36 kB +106 B +0.6%
@videojs/icons
Entry Base PR Diff %
./react 2.27 kB 2.27 kB 0 B 0%
./html 1.52 kB 1.52 kB 0 B 0%
total 3.79 kB 3.79 kB 0 B 0%
@videojs/store
Entry Base PR Diff %
. 1.29 kB 1.29 kB 0 B 0%
./html 468 B 468 B 0 B 0%
./react 204 B 204 B 0 B 0%
total 1.95 kB 1.95 kB 0 B 0%
@videojs/utils
Entry Base PR Diff %
./array 104 B 104 B 0 B 0%
./dom 928 B 928 B 0 B 0%
./events 227 B 227 B 0 B 0%
./function 261 B 261 B 0 B 0%
./object 119 B 119 B 0 B 0%
./predicate 265 B 265 B 0 B 0%
./string 148 B 148 B 0 B 0%
./style 185 B 185 B 0 B 0%
./time 478 B 478 B 0 B 0%
./number 158 B 158 B 0 B 0%
total 2.81 kB 2.81 kB 0 B 0%

ℹ️ How to interpret

Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

Volume slider custom element (<media-volume-slider>) that connects to
the player store for volume/mute state. Supports vertical orientation
and provides percentage-formatted context to shared slider children.
@mihar-22 mihar-22 force-pushed the feat/html-volume-slider branch from ba0b1eb to 1701426 Compare March 1, 2026 05:08
@mihar-22 mihar-22 marked this pull request as ready for review March 1, 2026 05:09
@mihar-22 mihar-22 merged commit 92b7c2a into main Mar 1, 2026
11 of 12 checks passed
@mihar-22 mihar-22 deleted the feat/html-volume-slider branch March 1, 2026 05:09
@github-actions github-actions bot mentioned this pull request Mar 10, 2026
This was referenced Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant