Skip to content

fix(html): move @videojs/icons to devDependencies#712

Merged
decepulis merged 2 commits intomainfrom
fix/icons-dependency-type
Mar 4, 2026
Merged

fix(html): move @videojs/icons to devDependencies#712
decepulis merged 2 commits intomainfrom
fix/icons-dependency-type

Conversation

@decepulis
Copy link
Copy Markdown
Collaborator

Summary

  • Moves @videojs/icons from dependencies to devDependencies in packages/html/package.json
  • PR feat(skin): implement default and minimal skins for HTML player #698 (feat(skin)) inadvertently added it to dependencies, causing No matching version found for @videojs/icons@10.0.0-alpha.5 errors for consumers since @videojs/icons is not published to npm
  • Icons are bundled at build time and not needed as a runtime dependency

Test plan

  • Verify pnpm install works cleanly from a fresh consumer project using @videojs/html@10.0.0-alpha.6

🤖 Generated with Claude Code

PR #698 (feat(skin)) added @videojs/icons to dependencies instead of
devDependencies, causing `No matching version found for
@videojs/icons@10.0.0-alpha.5` errors for consumers. Icons are bundled
at build time and not needed at runtime.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit cf21a6f
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69a89534c21d670008d6bfc1
😎 Deploy Preview https://deploy-preview-712--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

CI Failure Diagnosis

File Type What failed
packages/html/package.json build Lockfile out of date — @videojs/icons is in pnpm-lock.yaml but removed from package.json dependencies. Run pnpm install and commit the updated lockfile.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

📦 Bundle Size Report

Package Size Diff %
@videojs/core 10.41 kB 0 B ░░░░░░░░ 0%
@videojs/element 1.60 kB 0 B ░░░░░░░░ 0%
@videojs/html 26.95 kB 0 B ░░░░░░░░ 0%
@videojs/icons 7.49 kB 0 B ░░░░░░░░ 0%
@videojs/react 15.08 kB 0 B ░░░░░░░░ 0%
@videojs/store 1.96 kB 0 B ░░░░░░░░ 0%
@videojs/utils 2.81 kB 0 B ░░░░░░░░ 0%

Total: 66.30 kB · 0 B · 0%


Entry Breakdown

Subpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.

@videojs/core
Entry Base PR Diff %
. 4.39 kB 4.39 kB 0 B 0%
./dom 6.02 kB 6.02 kB 0 B 0%
total 10.41 kB 10.41 kB 0 B 0%
@videojs/element
Entry Base PR Diff %
. 817 B 817 B 0 B 0%
./context 823 B 823 B 0 B 0%
total 1.60 kB 1.60 kB 0 B 0%
@videojs/html
Entry Base PR Diff %
. 15.47 kB 15.47 kB 0 B 0%
./video 9.41 kB 9.41 kB 0 B 0%
./audio 1.04 kB 1.04 kB 0 B 0%
./background 1.03 kB 1.03 kB 0 B 0%
total 26.95 kB 26.95 kB 0 B 0%
@videojs/icons
Entry Base PR Diff %
./react 2.27 kB 2.27 kB 0 B 0%
./html 1.52 kB 1.52 kB 0 B 0%
./render 1.59 kB 1.59 kB 0 B 0%
./element 2.11 kB 2.11 kB 0 B 0%
total 7.49 kB 7.49 kB 0 B 0%
@videojs/store
Entry Base PR Diff %
. 1.31 kB 1.31 kB 0 B 0%
./html 472 B 472 B 0 B 0%
./react 199 B 199 B 0 B 0%
total 1.96 kB 1.96 kB 0 B 0%
@videojs/utils
Entry Base PR Diff %
./array 104 B 104 B 0 B 0%
./dom 928 B 928 B 0 B 0%
./events 227 B 227 B 0 B 0%
./function 261 B 261 B 0 B 0%
./object 119 B 119 B 0 B 0%
./predicate 265 B 265 B 0 B 0%
./string 148 B 148 B 0 B 0%
./style 185 B 185 B 0 B 0%
./time 478 B 478 B 0 B 0%
./number 158 B 158 B 0 B 0%
total 2.81 kB 2.81 kB 0 B 0%

ℹ️ How to interpret

Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

@decepulis decepulis merged commit 391cf5e into main Mar 4, 2026
19 checks passed
@decepulis decepulis deleted the fix/icons-dependency-type branch March 4, 2026 20:27
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
@github-actions github-actions bot mentioned this pull request Mar 10, 2026
@luwes luwes mentioned this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants