Skip to content

revert(html): remove double raf hls destroy#754

Merged
mihar-22 merged 1 commit intomainfrom
fix/revert-hls-raf-destroy
Mar 6, 2026
Merged

revert(html): remove double raf hls destroy#754
mihar-22 merged 1 commit intomainfrom
fix/revert-hls-raf-destroy

Conversation

@mihar-22
Copy link
Copy Markdown
Member

@mihar-22 mihar-22 commented Mar 6, 2026

Summary

Revert the double requestAnimationFrame guard on hls-video disconnect — destroy immediately when keep-alive is absent.

Changes

  • Remove double rAF + isConnected check from disconnectedCallback, call destroy() directly

Testing

Covered by existing tests.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 6, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 1cc3f72
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69aa7d47dc96b400089fb874
😎 Deploy Preview https://deploy-preview-754--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mihar-22 mihar-22 changed the title revert(html): remove double rAF from hls-video disconnect destroy revert(html): remove double rAF from hls destroy Mar 6, 2026
@mihar-22 mihar-22 changed the title revert(html): remove double rAF from hls destroy revert(html): remove double raf hls destroy Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

📦 Bundle Size Report

🎨 @videojs/html

(no changes)

Presets (7)
Entry Size
/video (default) 18.10 kB
/video (default + hls) 148.55 kB
/video (minimal) 18.15 kB
/video (minimal + hls) 148.51 kB
/audio (default) 6.24 kB
/audio (minimal) 6.25 kB
/background 6.29 kB
Media (3)
Entry Size
/media/background-video 652 B
/media/container 1.72 kB
/media/hls-video 131.11 kB
Players (3)
Entry Size
/video/player 6.16 kB
/audio/player 6.15 kB
/background/player 6.14 kB
Skins (12)
Entry Type Size
/video/minimal-skin.css css 2.51 kB
/video/skin.css css 2.52 kB
/video/minimal-skin js 17.58 kB
/video/minimal-skin.tailwind js 20.48 kB
/video/skin js 17.54 kB
/video/skin.tailwind js 20.06 kB
/audio/minimal-skin.css css 77 B
/audio/skin.css css 70 B
/audio/minimal-skin js 933 B
/audio/skin js 925 B
/background/skin.css css 124 B
/background/skin js 1008 B
UI Components (21)
Entry Size
/ui/alert-dialog 2.08 kB
/ui/alert-dialog-close 1.25 kB
/ui/alert-dialog-description 1.12 kB
/ui/alert-dialog-title 1.13 kB
/ui/buffering-indicator 1.76 kB
/ui/captions-button 1.81 kB
/ui/controls 1.78 kB
/ui/fullscreen-button 1.80 kB
/ui/mute-button 1.78 kB
/ui/pip-button 1.80 kB
/ui/play-button 1.80 kB
/ui/playback-rate-button 1.83 kB
/ui/popover 2.32 kB
/ui/poster 1.68 kB
/ui/seek-button 1.79 kB
/ui/slider 2.23 kB
/ui/thumbnail 2.17 kB
/ui/time 1.86 kB
/ui/time-slider 3.43 kB
/ui/tooltip 3.10 kB
/ui/volume-slider 2.14 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react

(no changes)

Presets (7)
Entry Size
/video (default) 15.81 kB
/video (default + hls) 146.38 kB
/video (minimal) 15.80 kB
/video (minimal + hls) 146.52 kB
/audio (default) 3.07 kB
/audio (minimal) 3.07 kB
/background 3.21 kB
Media (2)
Entry Size
/media/background-video 539 B
/media/hls-video 131.46 kB
Skins (12)
Entry Type Size
/video/minimal-skin.css css 2.51 kB
/video/skin.css css 2.52 kB
/video/minimal-skin js 15.71 kB
/video/minimal-skin.tailwind js 18.57 kB
/video/skin js 15.71 kB
/video/skin.tailwind js 18.19 kB
/audio/minimal-skin.css css 55 B
/audio/skin.css css 47 B
/audio/minimal-skin js 106 B
/audio/skin js 102 B
/background/skin.css css 91 B
/background/skin js 266 B
UI Components (17)
Entry Size
/ui/alert-dialog 2.77 kB
/ui/buffering-indicator 2.21 kB
/ui/captions-button 2.37 kB
/ui/controls 2.25 kB
/ui/fullscreen-button 2.27 kB
/ui/mute-button 2.30 kB
/ui/pip-button 2.33 kB
/ui/play-button 2.28 kB
/ui/playback-rate-button 2.29 kB
/ui/popover 2.98 kB
/ui/poster 2.08 kB
/ui/seek-button 2.27 kB
/ui/slider 2.99 kB
/ui/time 2.39 kB
/ui/time-slider 3.28 kB
/ui/tooltip 2.37 kB
/ui/volume-slider 3.17 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core

(no changes)

Entries (4)
Entry Size
. 4.75 kB
/dom 8.05 kB
/dom/media/custom-media-element 1.76 kB
/dom/media/hls 131.07 kB

🏷️ @videojs/element

(no changes)

Entries (2)
Entry Size
. 999 B
/context 936 B

📦 @videojs/store

(no changes)

Entries (3)
Entry Size
. 1.32 kB
/html 700 B
/react 360 B

🔧 @videojs/utils

(no changes)

Entries (10)
Entry Size
/array 104 B
/dom 1.07 kB
/events 227 B
/function 261 B
/object 119 B
/predicate 265 B
/string 148 B
/style 185 B
/time 478 B
/number 158 B

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

@mihar-22 mihar-22 marked this pull request as ready for review March 6, 2026 07:08
@mihar-22 mihar-22 merged commit dce16ae into main Mar 6, 2026
18 of 19 checks passed
@mihar-22 mihar-22 deleted the fix/revert-hls-raf-destroy branch March 6, 2026 07:08
This was referenced Mar 6, 2026
@luwes luwes mentioned this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant