Skip to content

chore: fix repo biome lint errors#804

Merged
mihar-22 merged 2 commits intomainfrom
codex/fix-lint-errors
Mar 10, 2026
Merged

chore: fix repo biome lint errors#804
mihar-22 merged 2 commits intomainfrom
codex/fix-lint-errors

Conversation

@mihar-22
Copy link
Copy Markdown
Member

Fixes Biome lint/format errors across core, spf, and site files, and updates Biome config includes to skip generated folders that were causing noisy failures.\n\nValidation:

video.js@0.1.0 lint /Users/rahimalwer/.codex/worktrees/7b1c/main
biome check .

Checked 1242 files in 220ms. No fixes applied. passes.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Mar 10, 2026 4:08am

Request Review

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 10, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit f8b1e44
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69af9920298019000861553a
😎 Deploy Preview https://deploy-preview-804--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

CI Failure Diagnosis

File Type What failed
packages/spf/src/dom/features/update-duration.ts:79 typecheck boolean | undefined is not assignable to boolean (TS2322).
(build, typecheck, test jobs) build All downstream jobs fail because @videojs/spf build fails due to the above type error.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html

(no changes)

Presets (7)
Entry Size
/video (default) 22.98 kB
/video (default + hls) 153.46 kB
/video (minimal) 22.84 kB
/video (minimal + hls) 153.15 kB
/audio (default) 21.17 kB
/audio (minimal) 21.16 kB
/background 6.36 kB
Media (4)
Entry Size
/media/background-video 652 B
/media/container 1.86 kB
/media/hls-video 131.32 kB
/media/simple-hls-video 11.38 kB
Players (3)
Entry Size
/video/player 6.22 kB
/audio/player 6.21 kB
/background/player 6.21 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 2.74 kB
/video/skin.css css 2.79 kB
/video/minimal-skin js 22.19 kB
/video/minimal-skin.tailwind js 21.48 kB
/video/skin js 22.37 kB
/video/skin.tailwind js 21.52 kB
/audio/minimal-skin.css css 2.17 kB
/audio/skin.css css 2.19 kB
/audio/minimal-skin js 20.59 kB
/audio/minimal-skin.tailwind js 19.69 kB
/audio/skin js 20.60 kB
/audio/skin.tailwind js 19.91 kB
/background/skin.css css 124 B
/background/skin js 1009 B
UI Components (21)
Entry Size
/ui/alert-dialog 2.03 kB
/ui/alert-dialog-close 1.25 kB
/ui/alert-dialog-description 1.15 kB
/ui/alert-dialog-title 1.13 kB
/ui/buffering-indicator 1.69 kB
/ui/captions-button 1.73 kB
/ui/controls 1.76 kB
/ui/fullscreen-button 1.78 kB
/ui/mute-button 1.75 kB
/ui/pip-button 1.78 kB
/ui/play-button 1.74 kB
/ui/playback-rate-button 1.77 kB
/ui/popover 3.01 kB
/ui/poster 1.64 kB
/ui/seek-button 1.75 kB
/ui/slider 2.20 kB
/ui/thumbnail 2.06 kB
/ui/time 1.82 kB
/ui/time-slider 2.92 kB
/ui/tooltip 2.43 kB
/ui/volume-slider 2.20 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react

(no changes)

Presets (7)
Entry Size
/video (default) 16.68 kB
/video (default + hls) 147.57 kB
/video (minimal) 16.67 kB
/video (minimal + hls) 147.48 kB
/audio (default) 14.36 kB
/audio (minimal) 14.42 kB
/background 3.14 kB
Media (3)
Entry Size
/media/background-video 539 B
/media/hls-video 131.60 kB
/media/simple-hls-video 11.73 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 2.74 kB
/video/skin.css css 2.79 kB
/video/minimal-skin js 16.59 kB
/video/minimal-skin.tailwind js 19.15 kB
/video/skin js 16.57 kB
/video/skin.tailwind js 19.26 kB
/audio/minimal-skin.css css 2.17 kB
/audio/skin.css css 2.19 kB
/audio/minimal-skin js 14.29 kB
/audio/minimal-skin.tailwind js 16.14 kB
/audio/skin js 14.26 kB
/audio/skin.tailwind js 16.30 kB
/background/skin.css css 90 B
/background/skin js 272 B
UI Components (17)
Entry Size
/ui/alert-dialog 2.71 kB
/ui/buffering-indicator 2.20 kB
/ui/captions-button 2.26 kB
/ui/controls 2.23 kB
/ui/fullscreen-button 2.26 kB
/ui/mute-button 2.25 kB
/ui/pip-button 2.21 kB
/ui/play-button 2.25 kB
/ui/playback-rate-button 2.26 kB
/ui/popover 3.08 kB
/ui/poster 2.02 kB
/ui/seek-button 2.24 kB
/ui/slider 3.09 kB
/ui/time 2.39 kB
/ui/time-slider 3.24 kB
/ui/tooltip 3.22 kB
/ui/volume-slider 3.08 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core

(no changes)

Entries (5)
Entry Size
. 4.78 kB
/dom 8.01 kB
/dom/media/custom-media-element 1.77 kB
/dom/media/hls 131.18 kB
/dom/media/simple-hls 11.23 kB

🏷️ @videojs/element

(no changes)

Entries (2)
Entry Size
. 999 B
/context 936 B

📦 @videojs/store

(no changes)

Entries (3)
Entry Size
. 1.32 kB
/html 700 B
/react 360 B

🔧 @videojs/utils

(no changes)

Entries (10)
Entry Size
/array 104 B
/dom 1003 B
/events 227 B
/function 261 B
/object 119 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B

📦 @videojs/spf

(no changes)

Entries (3)
Entry Size
. 40 B
/dom 9.48 kB
/playback-engine 9.37 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

@mihar-22 mihar-22 marked this pull request as ready for review March 10, 2026 04:10
@mihar-22 mihar-22 merged commit bd4e47b into main Mar 10, 2026
20 checks passed
@mihar-22 mihar-22 deleted the codex/fix-lint-errors branch March 10, 2026 04:10
sampotts pushed a commit that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant