Skip to content

chore(changelog): use one root level changelog#900

Merged
luwes merged 1 commit intomainfrom
root-changelog
Mar 11, 2026
Merged

chore(changelog): use one root level changelog#900
luwes merged 1 commit intomainfrom
root-changelog

Conversation

@luwes
Copy link
Copy Markdown
Collaborator

@luwes luwes commented Mar 11, 2026

fix #461

@luwes luwes requested a review from Copilot March 11, 2026 22:45
@luwes luwes self-assigned this Mar 11, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 11, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit f8b1a9a
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69b1f08ef6fde800082b1924
😎 Deploy Preview https://deploy-preview-900--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Mar 11, 2026 10:45pm

Request Review

@luwes luwes merged commit 1441c35 into main Mar 11, 2026
20 of 21 checks passed
@luwes luwes deleted the root-changelog branch March 11, 2026 22:46
@github-actions
Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html

(no changes)

Presets (7)
Entry Size
/video (default) 21.81 kB
/video (default + hls) 152.27 kB
/video (minimal) 21.59 kB
/video (minimal + hls) 151.79 kB
/audio (default) 20.49 kB
/audio (minimal) 20.50 kB
/background 6.47 kB
Media (4)
Entry Size
/media/background-video 617 B
/media/container 1.91 kB
/media/hls-video 131.23 kB
/media/simple-hls-video 11.91 kB
Players (3)
Entry Size
/video/player 6.33 kB
/audio/player 6.32 kB
/background/player 6.31 kB
Skins (15)
Entry Type Size
/video/minimal-skin.css css 2.57 kB
/video/skin.css css 2.62 kB
/video/minimal-skin js 21.00 kB
/video/minimal-skin.tailwind js 21.17 kB
/video/skin js 21.17 kB
/video/skin.tailwind js 21.42 kB
/audio/minimal-skin.css css 2.17 kB
/audio/skin.css css 2.19 kB
/audio/minimal-skin js 19.95 kB
/audio/minimal-skin.tailwind js 19.76 kB
/audio/skin js 19.96 kB
/audio/skin.tailwind js 19.97 kB
/background/skin.css css 124 B
/background/skin js 999 B
/base.css css 205 B
UI Components (21)
Entry Size
/ui/alert-dialog 2.07 kB
/ui/alert-dialog-close 1.27 kB
/ui/alert-dialog-description 1.55 kB
/ui/alert-dialog-title 1.53 kB
/ui/buffering-indicator 1.77 kB
/ui/captions-button 1.79 kB
/ui/controls 1.82 kB
/ui/fullscreen-button 1.82 kB
/ui/mute-button 1.83 kB
/ui/pip-button 1.81 kB
/ui/play-button 1.78 kB
/ui/playback-rate-button 1.82 kB
/ui/popover 3.18 kB
/ui/poster 1.69 kB
/ui/seek-button 1.80 kB
/ui/slider 2.00 kB
/ui/thumbnail 2.09 kB
/ui/time 1.63 kB
/ui/time-slider 2.94 kB
/ui/tooltip 2.45 kB
/ui/volume-slider 2.16 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react

(no changes)

Presets (7)
Entry Size
/video (default) 16.73 kB
/video (default + hls) 147.44 kB
/video (minimal) 16.77 kB
/video (minimal + hls) 147.57 kB
/audio (default) 14.44 kB
/audio (minimal) 14.48 kB
/background 3.19 kB
Media (3)
Entry Size
/media/background-video 539 B
/media/hls-video 131.52 kB
/media/simple-hls-video 12.26 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 2.57 kB
/video/skin.css css 2.62 kB
/video/minimal-skin js 16.63 kB
/video/minimal-skin.tailwind js 19.23 kB
/video/skin js 16.62 kB
/video/skin.tailwind js 19.33 kB
/audio/minimal-skin.css css 2.17 kB
/audio/skin.css css 2.19 kB
/audio/minimal-skin js 14.38 kB
/audio/minimal-skin.tailwind js 16.21 kB
/audio/skin js 14.35 kB
/audio/skin.tailwind js 16.38 kB
/background/skin.css css 90 B
/background/skin js 272 B
UI Components (17)
Entry Size
/ui/alert-dialog 2.73 kB
/ui/buffering-indicator 2.19 kB
/ui/captions-button 2.26 kB
/ui/controls 2.19 kB
/ui/fullscreen-button 2.27 kB
/ui/mute-button 2.27 kB
/ui/pip-button 2.25 kB
/ui/play-button 2.26 kB
/ui/playback-rate-button 2.27 kB
/ui/popover 3.10 kB
/ui/poster 2.03 kB
/ui/seek-button 2.30 kB
/ui/slider 3.09 kB
/ui/time 2.37 kB
/ui/time-slider 2.80 kB
/ui/tooltip 3.22 kB
/ui/volume-slider 2.73 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core

(no changes)

Entries (5)
Entry Size
. 4.78 kB
/dom 8.07 kB
/dom/media/custom-media-element 1.76 kB
/dom/media/hls 131.14 kB
/dom/media/simple-hls 11.76 kB

🏷️ @videojs/element

(no changes)

Entries (2)
Entry Size
. 999 B
/context 936 B

📦 @videojs/store

(no changes)

Entries (3)
Entry Size
. 1.32 kB
/html 700 B
/react 360 B

🔧 @videojs/utils

(no changes)

Entries (10)
Entry Size
/array 104 B
/dom 1003 B
/events 227 B
/function 261 B
/object 119 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B

📦 @videojs/spf

(no changes)

Entries (3)
Entry Size
. 40 B
/dom 10.03 kB
/playback-engine 9.93 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s release-please manifest configuration so changelog entries for all packages in the monorepo are written to a single root-level CHANGELOG.md (addressing #461).

Changes:

  • Set a root-level changelog-path in the release-please config.
  • Override each package’s changelog-path to point to the root CHANGELOG.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +33 to 35
"versioning": "prerelease",
"changelog-path": "../../CHANGELOG.md"
},
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching all packages to write into a single root-level CHANGELOG means the existing per-package packages/*/CHANGELOG.md files will stop being updated and can quickly become misleading. Consider either removing those per-package changelogs (or replacing them with a short pointer to the root CHANGELOG) as part of this change so consumers don’t read stale release notes.

Copilot uses AI. Check for mistakes.
Comment on lines 78 to 84
"packages/utils": {
"component": "@videojs/utils",
"prerelease": true,
"prerelease-type": "beta",
"versioning": "prerelease"
"versioning": "prerelease",
"changelog-path": "../../CHANGELOG.md"
}
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog-path is duplicated across every package entry (all set to ../../CHANGELOG.md). This repetition increases the chance a future package gets added without the override and starts generating its own changelog again; consider consolidating this into a single default (if supported by release-please) or otherwise adding a simple guard/check to keep it consistent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root-level CHANGELOG.md

2 participants