Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 Bundle Size Report🎨 @videojs/html(no changes) Presets (7)
Media (4)
Players (3)
Skins (15)
UI Components (21)
Sizes are marginal over the root entry point. ⚛️ @videojs/react(no changes) Presets (7)
Media (3)
Skins (14)
UI Components (17)
Sizes are marginal over the root entry point. 🧩 @videojs/core(no changes) Entries (5)
🏷️ @videojs/element(no changes) Entries (2)
📦 @videojs/store(no changes) Entries (3)
🔧 @videojs/utils(no changes) Entries (10)
📦 @videojs/spf(no changes) Entries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s release-please manifest configuration so changelog entries for all packages in the monorepo are written to a single root-level CHANGELOG.md (addressing #461).
Changes:
- Set a root-level
changelog-pathin the release-please config. - Override each package’s
changelog-pathto point to the rootCHANGELOG.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "versioning": "prerelease", | ||
| "changelog-path": "../../CHANGELOG.md" | ||
| }, |
There was a problem hiding this comment.
Switching all packages to write into a single root-level CHANGELOG means the existing per-package packages/*/CHANGELOG.md files will stop being updated and can quickly become misleading. Consider either removing those per-package changelogs (or replacing them with a short pointer to the root CHANGELOG) as part of this change so consumers don’t read stale release notes.
| "packages/utils": { | ||
| "component": "@videojs/utils", | ||
| "prerelease": true, | ||
| "prerelease-type": "beta", | ||
| "versioning": "prerelease" | ||
| "versioning": "prerelease", | ||
| "changelog-path": "../../CHANGELOG.md" | ||
| } |
There was a problem hiding this comment.
changelog-path is duplicated across every package entry (all set to ../../CHANGELOG.md). This repetition increases the chance a future package gets added without the override and starts generating its own changelog again; consider consolidating this into a single default (if supported by release-please) or otherwise adding a simple guard/check to keep it consistent.
fix #461