fix(skin): remove overflow in minimal video skin#993
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html(no changes) Presets (7)
Media (5)
Players (3)
Skins (16)
UI Components (21)
Sizes are marginal over the root entry point. ⚛️ @videojs/react(no changes) Presets (7)
Media (4)
Skins (14)
UI Components (18)
Sizes are marginal over the root entry point. 🧩 @videojs/core(no changes) Entries (6)
🏷️ @videojs/element(no changes) Entries (2)
📦 @videojs/store(no changes) Entries (3)
🔧 @videojs/utils(no changes) Entries (10)
📦 @videojs/spf(no changes) Entries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts skin styling to prevent minimal-skin control overflow during hide/show transitions and to improve the visibility of the default skin’s inner border ring in dark mode.
Changes:
- Add
overflow: clip/overflow-clipto the minimal video root so transitioning controls don’t render outside the player bounds. - Increase the default skin dark-mode border ring opacity (white 10% → 15%) for better contrast.
- Minor Tailwind token consolidation for the minimal skin border ring classes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/skins/src/minimal/tailwind/video.tailwind.ts | Adds overflow-clip to minimal video root and consolidates dark ring utility string. |
| packages/skins/src/minimal/css/video.css | Adds overflow: clip to minimal video root to match Tailwind tokens and prevent overflow during transitions. |
| packages/skins/src/default/tailwind/video.tailwind.ts | Increases dark-mode ring opacity (dark:after:ring-white/15). |
| packages/skins/src/default/css/video.css | Adjusts dark-mode --media-border-color to 0.15 opacity to match updated Tailwind ring strength. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overflow: clipin the minimal skin so the controls don't overflow when transitioning out.