fix(player) Make provider classes fetchable directly#1428
Closed
artrixdotdev wants to merge 5 commits intovidstack:mainfrom
Closed
fix(player) Make provider classes fetchable directly#1428artrixdotdev wants to merge 5 commits intovidstack:mainfrom
artrixdotdev wants to merge 5 commits intovidstack:mainfrom
Conversation
Removes type export and just exports the raw provider class so it can be used and extended in custom providers
This reverts commit 4192942.
Just adds a helper function that allows anyone with access to the loader to freely get the constructor for the provider in case they need it for extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
#1425
Description:
Just adds a helper function that allows anyone with access to the loader to freely get the constructor for the provider in case they need it for extension.
Shouldn't change any functionality, it just moves the loader's import to a separate function.
Ready?
yes
Anything Else?
Comment
Review Process: