Remove early usage of chrome API#1480
Merged
mihar-22 merged 1 commit intovidstack:mainfrom Oct 24, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
N/A
Description:
When running Vidstack in a Capacitor app, the app fails to start because of a ReferenceError:
ReferenceError: chrome is not definedThis happens because tracks.ts directly references the
chromeAPI on import.This typically doesn't happen when the app is bundled into neatly split dependencies as Vite does by default, but when generating a single bundle that contains the entire app, the
chromeAPI will be accessed immediately regardless of the browser used.This PR prevents the
chromeAPI from being referenced early.Ready?
Yes
Anything Else?
No
Review Process: