Respect user preference for reduced motion when autoplaying#1532
Merged
mihar-22 merged 1 commit intovidstack:mainfrom Feb 16, 2025
Merged
Respect user preference for reduced motion when autoplaying#1532mihar-22 merged 1 commit intovidstack:mainfrom
mihar-22 merged 1 commit intovidstack:mainfrom
Conversation
jramke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
closes #1479
Description:
I already opened an issue and now had time to dig into the code.
When a user has reduced motion settings enabled in their system preferences, the player should respect this setting and not autoplay videos, regardless of the autoplay attribute value. This aligns with accessibility best practices and user preferences for reduced motion.
As a dev we could handle this with a simple check as @ianmiller347 already mentioned in the issue for example. But i think it would be a good practice to implement this directly so it works out of the box.
If the user prefers reduced motion and its autoplaying we throw during the
playand notattemptAutoplaymethod because theauto-play-failedevent is triggered by theplay-failevent. Maybe i overlooked something and this could be improved.Ready?
Yes
Anything Else?
No
Review Process: