feat(react player): allow react ^19.0.0#1574
Merged
mihar-22 merged 1 commit intovidstack:mainfrom Feb 16, 2025
Merged
Conversation
Closed
|
Ship it, we need it badly. |
Yes please! Thanks so much @jpeiniger and Vidstack team!! |
philcockfield
added a commit
to sys-repo/sys
that referenced
this pull request
Feb 11, 2025
Causes problem with Vidstack, which is not yet up to 19. See: vidstack/player#1574
|
Are there any issues with React 19? Could you please share what's wrong with the PR above? |
mihar-22
pushed a commit
that referenced
this pull request
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Issue: #1533
Description:
React 19 stable has been released some weeks ago, but @vidstack/react is not yet compatible with it yet.
This also makes it impossible to use it inside NextJS 15 projects.
Ready?
Dependencies have been upgraded, everything kept working as expected.
Review Process:
Check all functions in the react sandbox example with react 19 and 18.