Skip to content

Comments

Added timeDivider type to default slots.tsx#1581

Merged
mihar-22 merged 3 commits intovidstack:mainfrom
felipehertzer:main
Feb 16, 2025
Merged

Added timeDivider type to default slots.tsx#1581
mihar-22 merged 3 commits intovidstack:mainfrom
felipehertzer:main

Conversation

@felipehertzer
Copy link
Contributor

@felipehertzer felipehertzer commented Feb 14, 2025

Description

I added a missing slot value, timeDivider , in the Default Component. This slot is already used in the Time Component, but it was missing from the Default Component, leading to inconsistency in the layout.

Reference to the relevant code:
[Time Component - Line 26](

{slot(slots, 'timeSeparator', <div className="vds-time-divider">/</div>)}
)

Example Usage

<DefaultVideoLayout 
  icons={defaultLayoutIcons} 
  slots={{ timeDivider: ' - ' }} 
/>

Ready?

Yes

@mihar-22
Copy link
Member

Thanks for the PR! We refer to it as "time divider" in the codebase, could we rename the slot to timeDivider?

@felipehertzer felipehertzer changed the title Added timeSeparator type to default slots.tsx Added timeDivider type to default slots.tsx Feb 16, 2025
@felipehertzer
Copy link
Contributor Author

felipehertzer commented Feb 16, 2025

Hey @mihar-22, done, I renamed to timeDivider

@mihar-22 mihar-22 merged commit fc86c72 into vidstack:main Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants