Added timeDivider type to default slots.tsx#1581
Merged
mihar-22 merged 3 commits intovidstack:mainfrom Feb 16, 2025
Merged
Conversation
Member
|
Thanks for the PR! We refer to it as "time divider" in the codebase, could we rename the slot to |
Contributor
Author
|
Hey @mihar-22, done, I renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a missing slot value,
timeDivider, in the Default Component. This slot is already used in the Time Component, but it was missing from the Default Component, leading to inconsistency in the layout.Reference to the relevant code:
[Time Component - Line 26](
player/packages/react/src/components/layouts/default/ui/time.tsx
Line 26 in 36cdc06
Example Usage
Ready?
Yes