ADR-011 assessment and D-06 resolution#19
Merged
Conversation
Documents what we know vs don't know, the core risk (can't verify output without LFS/Appwrite/views-pipeline-core), 4 prerequisites for safe implementation, and 4 possible approaches with pros/cons. Recommendation: build alongside (additive), don't replace, verify with real data before switching. Or wait for infrastructure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Major additions: - views-faoapi identified as the Appwrite-to-FAO bridge (answers D-06) - Complete data flow diagrams for both historical and forecast streams - Forecast stream is completely independent of datafactory — mapper needed for both - Viewser-to-datafactory migration history and nokgi semantic difference - orange_ensemble ghost reference (views-models #77) - Option C (factory GAUL columns) doesn't solve the forecast stream - Option D (hybrid) creates inconsistency between historical and forecast - Cross-repo risk register entries affecting this repo - Recommendation: read views-faoapi first, build alongside second Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rmed Investigation of views-faoapi confirms: - FAOApiManager passes postprocessor columns through unmodified - dataframe_to_dict() serves raw records, no renaming - FAO_PGMDataset._METADATA_COLS hardcodes postprocessor column names - The column renaming from RN01 Topic C was never implemented - FAO receives country_iso_a3, admin1_gaul1_code, pg_xcoord — NOT the contract-specified UN M49, ADM1_CODE, lat D-06 resolved as Possibility B: genuine gap, not this repo's fix. C-24 updated: renaming belongs in views-faoapi, not postprocessor. Assessment document Section 7 rewritten with definitive findings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only PR. No source code changes. Adds the ADR-011 implementation assessment and resolves the D-06 schema question.
ADR-011 Implementation Assessment (
docs/ADR-011_implementation_assessment.md)Comprehensive analysis of what's needed to replace the runtime mapper with a precomputed lookup table:
D-06 Resolution
Investigated views-faoapi code. Definitive finding: views-faoapi does NOT rename columns. The postprocessor's
country_iso_a3,admin1_gaul1_code,pg_xcoordreach FAO as-is viadataframe_to_dict(). The column renaming from Release Note 01 Topic C (UN M49,ADM1_CODE,lat) was never implemented in any repo. This is a real schema gap, but it belongs in views-faoapi to fix, not here.Risk Register Updates
GitHub Issues Created
9 issues (#10-#18) covering every actionable risk register concern:
Test plan
🤖 Generated with Claude Code