-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
area:ciCI/CD, GitHub Actions, workflowsCI/CD, GitHub Actions, workflowsarea:workspaceWorkspace tooling, justfile, templatesWorkspace tooling, justfile, templateschoreGeneral tasks (e.g. update dependencies, contact a manufacturer, read a paper)General tasks (e.g. update dependencies, contact a manufacturer, read a paper)effort:smallLess than 1 hourLess than 1 hourpriority:lowNice to have, do when capacity allowsNice to have, do when capacity allowssemver:patchBug fix, backward-compatibleBug fix, backward-compatible
Description
Chore Type
CI / Build change
Description
assets/smoke-test/.github/workflows/repository-dispatch.yml no longer invokes reusable workflows via
uses: ./.github/workflows/ci.yml and uses: ./.github/workflows/ci-container.yml.
The workspace template workflows still declare on.workflow_call:
assets/workspace/.github/workflows/ci.ymlassets/workspace/.github/workflows/ci-container.yml
This issue tracks removing obsolete reusable-workflow entry points and any now-stale rationale comments tied to that mode.
Acceptance Criteria
- Confirm there are no active callers that rely on
workflow_callfor workspace CI templates - Remove
workflow_callfromassets/workspace/.github/workflows/ci.yml - Remove
workflow_callfromassets/workspace/.github/workflows/ci-container.yml - Remove/update related permission comments that only apply to reusable-workflow mode
- Validate workflow syntax and trigger behavior for PR + workflow_dispatch paths
- Update docs/changelog only if user-visible behavior or documented trigger model changes
Implementation Notes
Target files:
assets/workspace/.github/workflows/ci.ymlassets/workspace/.github/workflows/ci-container.yml- (optional, if needed) docs that mention reusable invocation assumptions
Keep diff minimal and scoped to trigger/permission-comment cleanup.
Related Issues
Priority
Low
Changelog Category
Changed
Additional Context
This came from review of current local state where repository-dispatch.yml orchestrates deploy/PR flow and relies on PR-triggered CI rather than reusable uses: calls.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:ciCI/CD, GitHub Actions, workflowsCI/CD, GitHub Actions, workflowsarea:workspaceWorkspace tooling, justfile, templatesWorkspace tooling, justfile, templateschoreGeneral tasks (e.g. update dependencies, contact a manufacturer, read a paper)General tasks (e.g. update dependencies, contact a manufacturer, read a paper)effort:smallLess than 1 hourLess than 1 hourpriority:lowNice to have, do when capacity allowsNice to have, do when capacity allowssemver:patchBug fix, backward-compatibleBug fix, backward-compatible