-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
area:testingTest infrastructure, BATS, pytestTest infrastructure, BATS, pytestbugSomething isn't workingSomething isn't workingpriority:blockingBlocks other work or a releaseBlocks other work or a releasesecurityVulnerability fixes or security improvementsVulnerability fixes or security improvements
Milestone
Description
Description
The CodeQL check run for PR #270 (check_run_id=66785943362) failed with 3 new high-severity alerts:
- Incomplete URL substring sanitization (3 occurrences)
All alerts are reported in tests/test_integration.py.
Steps to Reproduce
- Open PR checks for
https://github.com/vig-os/devcontainer/pull/270/checks. - Open the failed CodeQL run (
check_run_id=66785943362). - Inspect annotations and observe 3 findings titled Incomplete URL substring sanitization.
- See findings on:
tests/test_integration.py(line ~1200)tests/test_integration.py(line ~1214)tests/test_integration.py(line ~1468)
Expected Behavior
CodeQL security analysis passes with no high-severity URL sanitization alerts.
Actual Behavior
CodeQL reports 3 high-severity alerts and fails the check.
Environment
- OS: GitHub Actions runner (Linux)
- Container Runtime: Podman (invoked by integration tests)
- Image Version/Tag: PR
#270head (release/0.3.0) - Architecture: x86_64 (CI default)
Additional Context
- PR: chore: release 0.3.0 #270
- Check run: https://github.com/vig-os/devcontainer/runs/66785943362
- Branch alerts query: https://github.com/vig-os/devcontainer/security/code-scanning?query=pr%3A270+tool%3ACodeQL+is%3Aopen
Possible Solution
Replace substring-based URL trust checks with structured URL parsing and strict host validation (e.g., parse hostname and compare against an allowlist), then update tests accordingly so CodeQL no longer flags the pattern.
Changelog Category
Security
Acceptance Criteria
- All 3 CodeQL alerts are resolved for PR chore: release 0.3.0 #270.
- CodeQL check passes for the branch.
- TDD compliance (see
.cursor/rules/tdd.mdc)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:testingTest infrastructure, BATS, pytestTest infrastructure, BATS, pytestbugSomething isn't workingSomething isn't workingpriority:blockingBlocks other work or a releaseBlocks other work or a releasesecurityVulnerability fixes or security improvementsVulnerability fixes or security improvements