Skip to content

fix: remove invalid issue refs from smoke-test deploy commit#290

Merged
c-vigo merged 2 commits intorelease/0.3.0from
bugfix/284-smoke-test-dispatch-tag
Mar 13, 2026
Merged

fix: remove invalid issue refs from smoke-test deploy commit#290
c-vigo merged 2 commits intorelease/0.3.0from
bugfix/284-smoke-test-dispatch-tag

Conversation

@c-vigo
Copy link
Contributor

@c-vigo c-vigo commented Mar 13, 2026

Description

Fix smoke-test deploy commit traceability by removing an invalid local issue reference from automated chore: deploy <tag> commits generated in vig-os/devcontainer-smoke-test.
Also add a maintainer note in the template workflow that changes in this file require manual redeploy to the smoke-test repository and promotion through PRs to main.

Type of Change

  • feat -- New feature
  • fix -- Bug fix
  • docs -- Documentation only
  • chore -- Maintenance task (deps, config, etc.)
  • refactor -- Code restructuring (no behavior change)
  • test -- Adding or updating tests
  • ci -- CI/CD pipeline changes
  • build -- Build system or dependency changes
  • revert -- Reverts a previous commit
  • style -- Code style (formatting, whitespace)

Modifiers

  • Breaking change (!) -- This change breaks backward compatibility

Changes Made

  • assets/smoke-test/.github/workflows/repository-dispatch.yml
    • Remove Refs: #258 from the automated deploy commit body (invalid in smoke-test repo context)
    • Add a template note about manual redeploy/sync expectations for this workflow file
  • CHANGELOG.md
    • Add a 0.3.0 ### Fixed entry for issue #284

Changelog Entry

Fixed

  • Smoke-test deploy commit no longer references non-local issue IDs (#284)
    • assets/smoke-test/.github/workflows/repository-dispatch.yml no longer injects Refs: #258 into automated chore: deploy <tag> commits in the smoke-test repository
    • Added maintainer note that workflow-template changes require manual redeploy to vig-os/devcontainer-smoke-test and promotion through PRs to main

Testing

  • Tests pass locally (just test)
  • Manual testing performed (describe below)

Manual Testing Details

N/A

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly (edit docs/templates/, then run just docs)
  • I have updated CHANGELOG.md in the [Unreleased] section (and pasted the entry above)
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

Follow-up enhancement tracked in #289 for richer dispatch payload metadata and downstream completion reporting.

Refs: #284

@c-vigo c-vigo self-assigned this Mar 13, 2026
@c-vigo c-vigo merged commit 2ead98c into release/0.3.0 Mar 13, 2026
12 checks passed
@c-vigo c-vigo deleted the bugfix/284-smoke-test-dispatch-tag branch March 13, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant