Skip to content

Conversation

@vigo
Copy link
Owner

@vigo vigo commented Jan 5, 2026

No description provided.

@vigo vigo merged commit 7e47b56 into main Jan 5, 2026
1 check passed
@vigo vigo deleted the upgrade-bump-my-version branch January 5, 2026 14:46
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb98909dd6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 41 to +44
abort "Please provide valid revision: #{AVAILABLE_REVISIONS.join(',')}"
end

system "bumpversion #{args.revision}"
system "bump-my-version bump #{args.revision}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bump task still gated on old bumpversion binary

The bump task now executes bump-my-version bump ..., but it still depends on :has_bumpversion, which only checks for the legacy bumpversion executable. On a system where only the new bump-my-version CLI is installed (the expected setup after this commit), rake bump/rake release will abort before running because the preflight reports the old binary missing. Align the preflight check with the new command so releases can run.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants