add interface: create and delete fields, create datasheet #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayneyao
reviewed
Apr 28, 2022
vika/exceptions.py
Outdated
| @@ -1,3 +1,10 @@ | |||
| class SpaceInfoLack(Exception): | |||
Contributor
There was a problem hiding this comment.
这个错误不需要专门定义一个 Exception，算是 client 参数校验的问题。直接 raise Erorr("具体的信息和正确的做法") 。缺少空间信息, 这个说法太模糊，直接 vika.datasheet("dstId") => vika.space("spaceID").datasheet("dstId") 告诉用户怎么修改更好。
Exception 更加倾向于表示服务端抛出的错误。预期偶尔出现，用户需要 catch 解决的异常流程。
vika/datasheet/datasheet_manager.py
Outdated
| :example: | ||
| >>> vika = Vika('YOUR_API_TOKEN') | ||
| >>> req_data = {'name': 'table_name'} | ||
| >>> rep = vika.space('YOUR_SPACE_ID').datasheet.create(req_data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
fields.create,fields.delete,datasheet.createinterface and test example.