Conversation
|
Thank you. It seems ok to me. @osyo-manga @usagi How do you think? I prefer separate them by |
|
I think about adbefa2 c8a6c82 bc54412 , there are no problems. But, I have a one question for ecc8719 . These two keywords are no problems:
But, the other keywords does not exist at least in the C++11 spec(ref: N3337).
These keywords are unspecified in the C++11. And, the spec 29.4 defined:
And, these unspecified keywords has slightly different (ex.: "ATOMIC_BOOS_IS_LOCK_FREE" in the patch vs. "ATOMIC_BOOL_LOCK_FREE" in the spec.). Do you know the source of these keywords in the patch? I think good idea for the @mattn 's proposal to separate the files. |
|
Oops, those were just spelling mistakes while typing them in. I've pushed a corrected version. I don't understand @mattn's suggestion. |
|
Thank you patches :) |
|
@usagi @osyo-manga Thank to your reviews. @jwakely Ok, I'll merge it |
|
Thank you all. I merged it. |
|
Thank you @mattn :) |
__cplusplusmacrothread_localkeyword<atomic>macros