Debugger* buffers are not deleted on close#226
Merged
joonty merged 1 commit intovim-vdebug:masterfrom Sep 4, 2015
BlackIkeEagle:on-close-buffers-are-not-deleted
Merged
Debugger* buffers are not deleted on close#226joonty merged 1 commit intovim-vdebug:masterfrom BlackIkeEagle:on-close-buffers-are-not-deleted
joonty merged 1 commit intovim-vdebug:masterfrom
BlackIkeEagle:on-close-buffers-are-not-deleted
Conversation
When the debugging session is done and you close the debugger tab in vim, the Debugger* buffers are just hidden, not deleted. Change the check in the Window class back to 'self.buffer == None' from 'not self.is_open' to bail out of the destroy method. fixes #225 Signed-off-by: BlackEagle <ike.devolder@gmail.com>
Collaborator
|
Thanks @BlackIkeEagle, I'd obviously forgotten why I used |
joonty
added a commit
that referenced
this pull request
Sep 4, 2015
…eleted Debugger* buffers are not deleted on close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the debugging session is done and you close the debugger tab in
vim, the Debugger* buffers are just hidden, not deleted.
Change the check in the Window class back to 'self.buffer == None' from
'not self.is_open' to bail out of the destroy method.
fixes #225
Signed-off-by: BlackEagle ike.devolder@gmail.com